Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow decorating the wrapper with just the init-script but no Nokee version #42

Open
lacasseio opened this issue Feb 12, 2021 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@lacasseio
Copy link
Member

This allows to easily configure the plugin repositories for dev.nokee and dev.gradleplugins which is the case for this project.

@lacasseio lacasseio added the enhancement New feature or request label Feb 12, 2021
@lacasseio lacasseio added this to the 0.9.0 milestone Feb 12, 2021
@lacasseio
Copy link
Member Author

We should just change the behaviour to always decorate the Gradle wrapper, print a message to say that we did and if it's not something they want, they can just execute again with a flag -Dno-nokee or something like that.

@lacasseio
Copy link
Member Author

  • Print from the wrapper task when the decoration happens
  • Accept a flag that disable nokee decoration
  • Upon disabling nokee decoration delete the nokee.init.gradle script
  • Always decorate by default (without -Dnokee-version) which adds the init script, patch the wrapper scripts but does not write Gradle wrapper properties for the version (it should still write the hash property when that will be available).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant