Fix type annotations

Author: Dominikus Nold

.github/workflows/pr-orchestrator.yml

@@ -219,7 +219,8 @@ jobs:
       - name: Run type checking
         run: |
           echo "🔍 Running basedpyright type checking..."
-          hatch run type-check || echo "⚠️ Type checking incomplete"
+          # Fail on type errors (severity 8) to enforce type safety in CI/CD
+          hatch run type-check
 
   linting:
     name: Linting (ruff, pylint)

src/specfact_cli/commands/import_cmd.py

@@ -8,6 +8,7 @@
 from __future__ import annotations
 
 from pathlib import Path
+from typing import Optional
 
 import typer
 from beartype import beartype
@@ -277,7 +278,7 @@ def from_code(
         "--entry-point",
         help="Subdirectory path for partial analysis (relative to repo root). Analyzes only files within this directory and subdirectories.",
     ),
-    output_format: StructuredFormat | None = typer.Option(
+    output_format: Optional[StructuredFormat] = typer.Option(
         None,
         "--output-format",
         help="Plan bundle output format (yaml or json). Defaults to global --output-format.",

src/specfact_cli/commands/plan.py

@@ -11,7 +11,7 @@
 from contextlib import suppress
 from datetime import UTC
 from pathlib import Path
-from typing import Any
+from typing import Any, Optional
 
 import typer
 from beartype import beartype
@@ -68,7 +68,7 @@ def init(
         "--scaffold/--no-scaffold",
         help="Create complete .specfact directory structure",
     ),
-    output_format: StructuredFormat | None = typer.Option(
+    output_format: Optional[StructuredFormat] = typer.Option(
         None,
         "--output-format",
         help="Plan bundle format for output (yaml or json). Defaults to global --output-format.",

src/specfact_cli/utils/structured_io.py

@@ -4,12 +4,10 @@
 Provides helpers to load and dump JSON/YAML consistently with format detection.
 """
 
-from __future__ import annotations
-
 import json
 from enum import Enum
 from pathlib import Path
-from typing import Any
+from typing import Any, Optional
 
 from beartype import beartype
 from icontract import ensure, require
@@ -28,7 +26,7 @@ def __str__(self) -> str:  # pragma: no cover - convenience
 
     @classmethod
     @beartype
-    def from_string(cls, value: str | None, default: StructuredFormat | None = None) -> StructuredFormat:
+    def from_string(cls, value: str | None, default: Optional["StructuredFormat"] = None) -> "StructuredFormat":
         """
         Convert string to StructuredFormat (defaults to YAML).
 
@@ -45,7 +43,7 @@ def from_string(cls, value: str | None, default: StructuredFormat | None = None)
 
     @classmethod
     @beartype
-    def from_path(cls, path: Path | str | None, default: StructuredFormat | None = None) -> StructuredFormat:
+    def from_path(cls, path: Path | str | None, default: Optional["StructuredFormat"] = None) -> "StructuredFormat":
         """
         Infer format from file path suffix.