Fix codex review findings

Author: djm81

src/specfact_cli/modules/module_registry/module-package.yaml

@@ -1,5 +1,5 @@
 name: module-registry
-version: 0.1.4
+version: 0.1.5
 commands:
   - module
 command_help:
@@ -15,5 +15,5 @@ publisher:
 description: 'Manage modules: search, list, show, install, and upgrade.'
 license: Apache-2.0
 integrity:
-  checksum: sha256:d1c9a6082275c8b073b594214849bbdb0260dd6eba1e76cedebb90dd4d411653
-  signature: 2KCvzV/LqrHro8uhCCCD70bPtuxHtYSPLMr5CPHv2WS8KrculbtS282zdSXuUxcxDoavvjvF7h2LuTLKzMLqBA==
+  checksum: sha256:4837d40c55ebde6eba87b434c3ec3ae3d0d842eb6a6984d4212ffbc6fd26eac2
+  signature: m2tJyNfaHOnil3dsT5NxUB93+4nnVJHBaF7QzQf/DC8F/LG7oJJMWHU063HY9x2/d9hFVXLwItf9TNgNjnirDQ==

src/specfact_cli/modules/module_registry/src/commands.py

@@ -263,19 +263,16 @@ def uninstall(
 @beartype
 def alias_create(
     alias_name: str = typer.Argument(..., help="Alias (command name) to map"),
-    module_id: str = typer.Argument(..., help="Namespaced module id (e.g. acme-corp/backlog-pro)"),
+    command_name: str = typer.Argument(..., help="Command name to invoke (e.g. backlog, module)"),
     force: bool = typer.Option(False, "--force", help="Allow alias to shadow built-in command"),
 ) -> None:
-    """Create an alias mapping a command name to a namespaced module."""
-    if "/" not in module_id.strip():
-        console.print("[red]module_id must be namespace/name (e.g. acme-corp/backlog-pro).[/red]")
-        raise typer.Exit(1)
+    """Create an alias mapping a custom name to a registered command."""
     try:
-        create_alias(alias_name.strip(), module_id.strip(), force=force)
+        create_alias(alias_name.strip(), command_name.strip(), force=force)
     except ValueError as exc:
         console.print(f"[red]{exc}[/red]")
         raise typer.Exit(1) from exc
-    console.print(f"[green]Alias[/green] {alias_name!r} -> {module_id!r}")
+    console.print(f"[green]Alias[/green] {alias_name!r} -> {command_name!r}")
 
 
 @alias_app.command(name="list")
@@ -288,7 +285,7 @@ def alias_list() -> None:
         return
     table = Table(title="Aliases")
     table.add_column("Alias", style="cyan")
-    table.add_column("Module", style="green")
+    table.add_column("Command", style="green")
     for alias, mod in sorted(aliases.items()):
         table.add_row(alias, mod)
     console.print(table)
@@ -312,7 +309,7 @@ def alias_remove(
 @beartype
 def add_registry_cmd(
     url: str = typer.Argument(..., help="Registry index URL (e.g. https://company.com/index.json)"),
-    id: str = typer.Option(None, "--id", help="Registry id (default: derived from URL)"),
+    id: str | None = typer.Option(None, "--id", help="Registry id (default: derived from URL)"),
     priority: int | None = typer.Option(None, "--priority", help="Priority (default: next available)"),
     trust: str = typer.Option("prompt", "--trust", help="Trust level: always, prompt, or never"),
 ) -> None:

src/specfact_cli/registry/alias_manager.py

@@ -1,4 +1,4 @@
-"""Alias storage and resolution: command name -> namespaced module ID."""
+"""Alias storage and resolution: alias -> command name."""
 
 from __future__ import annotations
 
@@ -30,12 +30,12 @@ def _builtin_command_names() -> set[str]:
 
 @beartype
 @require(lambda alias: alias.strip() != "", "alias must be non-empty")
-@require(lambda module_id: "/" in module_id and len(module_id.strip()) > 0, "module_id must be namespace/name")
+@require(lambda command_name: command_name.strip() != "", "command_name must be non-empty")
 @ensure(lambda: True, "no postcondition on void")
-def create_alias(alias: str, module_id: str, force: bool = False) -> None:
-    """Store alias -> module_id in aliases.json. Warn or raise if alias shadows built-in."""
+def create_alias(alias: str, command_name: str, force: bool = False) -> None:
+    """Store alias -> command_name in aliases.json. Warn or raise if alias shadows built-in."""
     alias = alias.strip()
-    module_id = module_id.strip()
+    command_name = command_name.strip()
     path = get_aliases_path()
     path.parent.mkdir(parents=True, exist_ok=True)
     builtin = _builtin_command_names()
@@ -45,7 +45,7 @@ def create_alias(alias: str, module_id: str, force: bool = False) -> None:
     data = {}
     if path.exists():
         data = json.loads(path.read_text(encoding="utf-8"))
-    data[alias] = module_id
+    data[alias] = command_name
     path.write_text(json.dumps(data, indent=2), encoding="utf-8")
     if alias in builtin:
         logger.warning("Alias will shadow built-in module: %s", alias)
@@ -54,7 +54,7 @@ def create_alias(alias: str, module_id: str, force: bool = False) -> None:
 @beartype
 @ensure(lambda result: isinstance(result, dict), "returns dict")
 def list_aliases() -> dict[str, str]:
-    """Return all alias -> module_id mappings. Empty dict if file missing."""
+    """Return all alias -> command name mappings. Empty dict if file missing."""
     path = get_aliases_path()
     if not path.exists():
         return {}
@@ -87,9 +87,8 @@ def remove_alias(alias: str) -> None:
 @require(lambda invoked_name: isinstance(invoked_name, str), "invoked_name must be str")
 @ensure(lambda result: isinstance(result, str) and len(result) > 0, "returns non-empty string")
 def resolve_command(invoked_name: str) -> str:
-    """If invoked_name is an alias, return the module command name (last segment of module_id); else return invoked_name."""
+    """If invoked_name is an alias, return the stored command name; else return invoked_name."""
     aliases = list_aliases()
     if invoked_name in aliases:
-        module_id = aliases[invoked_name]
-        return module_id.rsplit("/", 1)[-1] if "/" in module_id else module_id
+        return aliases[invoked_name]
     return invoked_name

src/specfact_cli/registry/marketplace_client.py

@@ -73,7 +73,28 @@ def download_module(
 ) -> Path:
     """Download module tarball and verify SHA-256 checksum from registry metadata."""
     logger = get_bridge_logger(__name__)
-    registry_index = index if index is not None else fetch_registry_index()
+    if index is not None:
+        registry_index = index
+    else:
+        from specfact_cli.registry.custom_registries import fetch_all_indexes
+
+        registry_index = None
+        for _reg_id, idx in fetch_all_indexes(timeout=timeout):
+            if not isinstance(idx, dict):
+                continue
+            mods = idx.get("modules") or []
+            if not isinstance(mods, list):
+                continue
+            for c in mods:
+                if isinstance(c, dict) and c.get("id") == module_id:
+                    if version and c.get("latest_version") != version:
+                        continue
+                    registry_index = idx
+                    break
+            if registry_index is not None:
+                break
+        if registry_index is None:
+            registry_index = fetch_registry_index()
     if not registry_index:
         raise ValueError("Cannot install from marketplace (offline)")
 

tests/unit/registry/test_alias_manager.py

@@ -26,22 +26,22 @@ def test_get_aliases_path_returns_specfact_registry_path() -> None:
 
 
 def test_create_alias_stores_mapping(tmp_path: Path) -> None:
-    """create_alias() writes alias -> module_id to aliases.json."""
+    """create_alias() writes alias -> command name to aliases.json."""
     with patch("specfact_cli.registry.alias_manager.get_aliases_path", return_value=tmp_path / "aliases.json"):
-        create_alias("my-backlog", "acme-corp/backlog-pro")
+        create_alias("my-backlog", "backlog-pro")
     assert (tmp_path / "aliases.json").exists()
     data = json.loads((tmp_path / "aliases.json").read_text())
-    assert data == {"my-backlog": "acme-corp/backlog-pro"}
+    assert data == {"my-backlog": "backlog-pro"}
 
 
 def test_list_aliases_returns_all_aliases(tmp_path: Path) -> None:
-    """list_aliases() returns dict of alias -> module_id."""
+    """list_aliases() returns dict of alias -> command name."""
     aliases_file = tmp_path / "aliases.json"
     tmp_path.mkdir(parents=True, exist_ok=True)
-    aliases_file.write_text(json.dumps({"backlog": "acme/backlog-pro", "generate": "specfact/generate"}))
+    aliases_file.write_text(json.dumps({"backlog": "backlog-pro", "generate": "generate"}))
     with patch("specfact_cli.registry.alias_manager.get_aliases_path", return_value=aliases_file):
         result = list_aliases()
-    assert result == {"backlog": "acme/backlog-pro", "generate": "specfact/generate"}
+    assert result == {"backlog": "backlog-pro", "generate": "generate"}
 
 
 def test_list_aliases_returns_empty_when_file_missing() -> None:
@@ -64,10 +64,10 @@ def test_remove_alias_deletes_mapping(tmp_path: Path) -> None:
 
 
 def test_resolve_command_returns_module_command_name_when_aliased() -> None:
-    """resolve_command() returns the command name for the aliased module (last segment of module_id)."""
-    with patch("specfact_cli.registry.alias_manager.list_aliases", return_value={"backlog": "acme-corp/backlog-pro"}):
+    """resolve_command() returns the stored command name for the alias."""
+    with patch("specfact_cli.registry.alias_manager.list_aliases", return_value={"backlog": "backlog-pro"}):
         assert resolve_command("backlog") == "backlog-pro"
-    with patch("specfact_cli.registry.alias_manager.list_aliases", return_value={"gen": "specfact/generate"}):
+    with patch("specfact_cli.registry.alias_manager.list_aliases", return_value={"gen": "generate"}):
         assert resolve_command("gen") == "generate"
 
 
@@ -86,7 +86,7 @@ def test_create_alias_raises_when_shadowing_builtin_without_force(tmp_path: Path
         patch("specfact_cli.registry.alias_manager._builtin_command_names", return_value={"backlog", "module"}),
         pytest.raises(ValueError, match="shadow"),
     ):
-        create_alias("backlog", "acme/backlog-pro", force=False)
+        create_alias("backlog", "backlog-pro", force=False)
 
 
 def test_create_alias_with_force_stores_even_when_shadowing(tmp_path: Path) -> None:
@@ -95,6 +95,6 @@ def test_create_alias_with_force_stores_even_when_shadowing(tmp_path: Path) -> N
         patch("specfact_cli.registry.alias_manager.get_aliases_path", return_value=tmp_path / "aliases.json"),
         patch("specfact_cli.registry.alias_manager._builtin_command_names", return_value={"backlog"}),
     ):
-        create_alias("backlog", "acme/backlog-pro", force=True)
+        create_alias("backlog", "backlog-pro", force=True)
     data = json.loads((tmp_path / "aliases.json").read_text())
-    assert data.get("backlog") == "acme/backlog-pro"
+    assert data.get("backlog") == "backlog-pro"