do not actually need to unique_ptr here

Author: apage43

gpt4all-backend/llmodel.cpp

@@ -79,8 +79,8 @@ bool LLModel::Implementation::isImplementation(const Dlhandle &dl) {
 
 static bool s_scanned = false;
 
-const std::vector<std::unique_ptr<LLModel::Implementation>> &LLModel::Implementation::implementationList() {
-    static std::vector<std::unique_ptr<LLModel::Implementation>> s_impl_libs;
+const std::vector<LLModel::Implementation> &LLModel::Implementation::implementationList() {
+    static std::vector<LLModel::Implementation> s_impl_libs;
 
     if(s_scanned) { return s_impl_libs; }
     std::string impl_name_re = "(bert|llama|gptj|llamamodel-mainline)";
@@ -109,7 +109,7 @@ const std::vector<std::unique_ptr<LLModel::Implementation>> &LLModel::Implementa
                     if (!Implementation::isImplementation(dl)) {
                         continue;
                     }
-                    s_impl_libs.emplace_back(std::make_unique<Implementation>(std::move(dl)));
+                    s_impl_libs.emplace_back(Implementation(std::move(dl)));
                 } catch (...) {}
             }
         }
@@ -122,9 +122,9 @@ const std::vector<std::unique_ptr<LLModel::Implementation>> &LLModel::Implementa
 
 const LLModel::Implementation* LLModel::Implementation::implementation(const char *fname, const std::string& buildVariant) {
     for (const auto& i : implementationList()) {
-        if (buildVariant != i->m_buildVariant) continue;
-        if (!i->m_magicMatch(fname)) continue;
-        return i.get();
+        if (buildVariant != i.m_buildVariant) continue;
+        if (!i.m_magicMatch(fname)) continue;
+        return &i;
     }
     return nullptr;
 }

gpt4all-backend/llmodel.h

@@ -8,7 +8,6 @@
 #include <fstream>
 #include <cstdint>
 #include <limits>
-#include <memory>
 
 #define LLMODEL_MAX_PROMPT_BATCH 128
 
@@ -27,7 +26,7 @@ class LLModel {
         std::string_view buildVariant() const { return m_buildVariant; }
 
         static bool isImplementation(const Dlhandle&);
-        static const std::vector<std::unique_ptr<Implementation>>& implementationList();
+        static const std::vector<Implementation>& implementationList();
         static const Implementation *implementation(const char *fname, const std::string& buildVariant);
         static LLModel *construct(const std::string &modelPath, std::string buildVariant = "auto");
         static void setImplementationsSearchPath(const std::string& path);