Merge pull request #271 from ThomasTr/extend-options

Make Options extendable

Author: norkunas

src/Options.php

@@ -11,6 +11,7 @@
 use function in_array;
 use function str_contains;
 
+/** @phpstan-consistent-constructor */
 class Options
 {
     // @deprecated
@@ -250,7 +251,7 @@ class Options
      */
     private array $url = [];
 
-    private function __construct()
+    public function __construct()
     {
     }
 

tests/Fixtures/OptionsExtended.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace YoutubeDl\Tests\Fixtures;
+
+final class OptionsExtended extends \YoutubeDl\Options
+{
+    // Preset Aliases
+    private ?string $presetAlias = null;
+
+    public function presetAlias(?string $presetAlias): self
+    {
+        $new = clone $this;
+        $new->presetAlias = $presetAlias;
+
+        return $new;
+    }
+
+    public function toArray(): array
+    {
+        $array = parent::toArray();
+
+        $array['preset-alias'] = $this->presetAlias;
+
+        return $array;
+    }
+}

tests/OptionsTest.php

@@ -72,4 +72,11 @@ public function testOutputThrowsWithDirectorySeparator(): void
 
         Options::create()->output('/var/downloads');
     }
+
+    public function testExtendOutput(): void
+    {
+        $options = (new Fixtures\OptionsExtended())->toArray();
+
+        self::assertArrayHasKey('preset-alias', $options);
+    }
 }