[nrf noup] [west zap-gui] Refine error handling

It turns out that the subprocess may return no output
if the Chromium cannot use sandbox due to the missing
permissions. Added a workaround that raises an exception
if the command execution output is empty, so that it
can be handled with the fix_sandbox_permissions() call.

Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no>

Author: markaj-nordic

scripts/west/zap_common.py

@@ -299,13 +299,13 @@ def __exit__(self, exc_type, exc_val, exc_tb):
 
 def display_zap_message(output: subprocess.CompletedProcess[str]) -> None:
     """
-    If the output contains the error from napi_throw, suggest user to use zap-sync to sync the ZAP file.
+    If the output contains the error from napi_throw, suggest user to use zap-sync to sync the ZAP file and make sure that all attributes are provided.
     """
+    print(f"output: {output.stdout}")
     if 'Unknown attribute' in output.stdout:
-        log.err("Your zcl.json file seems to be outdated. Please use 'west zap-sync' command to synchronize it with the newest Matter Data Model.")
-        return
-    else:
-        print(f"output: {output.stdout}")
+        log.err("Your zcl.json file seems to be outdated or is missing some attributes. "
+                "Please use 'west zap-sync' command to synchronize it with the newest Matter Data Model "
+                "and make sure that all cluster attributes are properly defined in the cluster XML file.")
 
 
 class ZapInstaller:

scripts/west/zap_gui.py

@@ -102,6 +102,10 @@ def run_zap():
                     cmd += ["--tempState"]
 
                 output = subprocess.run([str(x) for x in cmd], capture_output=True, text=True)
+                # Chromium often prints nothing to stdout when the sandbox aborts early.
+                # returncode -5 is a sentinel consumed by fix_sandbox_permissions().
+                if not output.stdout:
+                    raise subprocess.CalledProcessError(-5, cmd)
                 display_zap_message(output)
                 return output