Skip to content

Commit ccd41c6

Browse files
chrisbeach59restyled-commitsbzbarsky-apple
authored
FIX TSTST-2.2 script (#20166)
* FIX TSTST-2.2 script Aligned the thermostat PICS in ci-pics-values with the feature map in all-clusters-app.zap HEAT | COOL | AUTO Updated the Test-TC-TSTAT_2_2.yaml to properly deal with AUTO MODE Validated all steps pass with HEAT, COOL, HEAT&COOL and those permutations along with OCC and AUTO. Addresses Test Plan issues 1379 and 1456 * Restyled by whitespace * Restyled by prettier-yaml * Update src/app/tests/suites/certification/ci-pics-values Co-authored-by: Boris Zbarsky <[email protected]> * Removing unintended change to ZAP file * Address CI issues * Restyled by whitespace * Restyled by prettier-yaml * remove ci pics values added incorrectly * align ci-pics and pics.yaml * Add TSTAT.S Features Added Feature flags 3 and 4 * REGEN Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
1 parent c04457c commit ccd41c6

File tree

7 files changed

+2118
-1591
lines changed

7 files changed

+2118
-1591
lines changed

.gitignore

+2-1
Original file line numberDiff line numberDiff line change
@@ -63,4 +63,5 @@ compile_commands.json
6363
*~
6464

6565
# log files
66-
*.log
66+
*.log
67+
examples/thermostat/ameba/build

src/app/tests/suites/certification/PICS.yaml

+13-23
Original file line numberDiff line numberDiff line change
@@ -604,12 +604,18 @@ PICS:
604604
- label: "Does the device implement the ResetWaterMarks command?"
605605
id: DGSW.S.C00
606606

607-
# Thermostat cluster
608-
- label: "Does the device implement the OccupiedCoolingSetpoint attribute"
609-
id: A_OCCUPIEDCOOLINGSETPOINT
607+
# Thermostat cluster
608+
- label: "Does the device implement the Heating feature"
609+
id: TSTAT.S.F00
610+
611+
- label: "Does the device implement the Cooling feature"
612+
id: TSTAT.S.F01
613+
614+
- label: "Does the device implement the Occupancy feature"
615+
id: TSTAT.S.F02
610616

611-
- label: "Does the device implement the OccupiedHeatingSetpoint attribute"
612-
id: A_OCCUPIEDHEATINGSETPOINT
617+
- label: "Does the device implement the Auto feature"
618+
id: TSTAT.S.F05
613619

614620
- label: "Does the device implement the MinHeatSetpointLimit attribute"
615621
id: A_MINHEATSETPOINTLIMIT
@@ -623,24 +629,8 @@ PICS:
623629
- label: "Does the device implement the MaxCoolSetpointLimit attribute"
624630
id: A_MAXCOOLSETPOINTLIMIT
625631

626-
- label:
627-
"Does the device implement the ControlSequenceOfOperation attribute"
628-
id: A_CONTROLSEQUENCEOFOPERATION
629-
630-
- label:
631-
"Does the device implement receiving the SetpointRaiseLower command?"
632-
id: CR_SetpointRaiseLower
633-
634-
- label:
635-
"Does the device implement the UnoccupiedCoolingSetpoint attribute?"
636-
id: A_UNOCCUPIEDCOOLINGSETPOINT
637-
638-
- label:
639-
"Does the device implement the UnoccupiedHeatingSetpoint attribute?"
640-
id: A_UNOCCUPIEDHEATINGSETPOINT
641-
642-
- label: "Does the device implement the MinSetpointDeadBand attribute?"
643-
id: A_MINSETPOINTDEADBAND
632+
- label: "Does the device implement the Tolerance attribute?"
633+
id: A_TEMPERATURE_TOLERANCE
644634

645635
- label: "Does the device implement the LocalTemperature attribute?"
646636
id: TSTAT.S.A0000

src/app/tests/suites/certification/Test_TC_TSTAT_1_1.yaml

-3
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@ tests:
3737
type: uint16
3838

3939
- label: "Read the optional global attribute constraints: FeatureMap"
40-
PICS:
41-
TSTAT.S.F00 || TSTAT.S.F01 || TSTAT.S.F02 || TSTAT.S.F03 ||
42-
TSTAT.S.F04 || TSTAT.S.F05
4340
command: "readAttribute"
4441
attribute: "FeatureMap"
4542
response:

0 commit comments

Comments
 (0)