Merge pull request #48 from nulab/issue-46/safe-stop-running-child-process

Stop the running child process when the connection is broken (#46)

Author: vvatanabe

Diff for: githttpxfer/githttpxfer.go

@@ -266,7 +266,11 @@ func (ghx *GitHTTPXfer) serviceRPC(ctx Context, rpc string) {
 	args := []string{rpc, "--stateless-rpc", "."}
 	cmd := ghx.Git.GitCommand(repoPath, args...)
 	cmd.Env = ctx.Env()
-	defer cleanUpProcessGroup(cmd)
+	defer cmd.Wait()
+	go func() {
+		<-req.Context().Done()
+		cleanUpProcessGroup(cmd)
+	}()
 
 	stdin, err := cmd.StdinPipe()
 	if err != nil {

Diff for: githttpxfer/support.go

@@ -22,5 +22,4 @@ func cleanUpProcessGroup(cmd *exec.Cmd) {
 	if process := cmd.Process; process != nil && process.Pid > 0 {
 		syscall.Kill(-process.Pid, syscall.SIGTERM)
 	}
-	cmd.Wait()
 }