Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure PPND will be okay with the latency of Pipeline/ISBService informers #232

Open
juliev0 opened this issue Sep 6, 2024 · 1 comment
Assignees

Comments

@juliev0
Copy link
Collaborator

juliev0 commented Sep 6, 2024

this is based on this comment


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@juliev0
Copy link
Collaborator Author

juliev0 commented Sep 6, 2024

I came up with at least one case where it wouldn't be good:
once PipelineRollout Reconciler has update the Pipeline spec, it will check to see if the Pipeline is still reconciling in order to know whether it can resume the Pipeline or not. If we get an old copy of the Pipeline spec whose generation still shows the previous generation, then its observedGeneration would in fact match the generation, and then we'd resume the Pipeline prematurely.

For this reason, I think if we currently have the PPND InProgressStrategy (saved in memory), then we should reach out to the K8S API to get the latest spec rather than just using the one from the Informer.

@xdevxy xdevxy added enhance PPND and removed enhancement New feature or request labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants