Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine how to handle ambiguous Child health conditions to determine if reconciliation is still happening (PPND) #239

Closed
juliev0 opened this issue Sep 9, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@juliev0
Copy link
Collaborator

juliev0 commented Sep 9, 2024

Describe the bug
PipelineRollout, ISBServiceRollout, and NumaflowController Rollout need to know whether the child resources of the Pipeline and ISBSvc, and whether the Numaflow Controller Deployment are done Progressing so they can safely unpause pipelines.

Pipeline and ISBsvc have Conditions which can indicate if their children are progressing: Condition.Reason=Progressing.

However, there are certain cases in which the Condition is set to false but it was ambiguous as to whether it was a case of "Progressing" or just general failure, so the Condition was not marked as "Progressing", namely I see this one:

{Type:DaemonServiceHealthy Status:False Reason:GetDaemonServiceFailed Message:Deployment not found, might be still under creation}

Message from the maintainers:

Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

@juliev0 juliev0 added the bug Something isn't working label Sep 9, 2024
@juliev0 juliev0 self-assigned this Sep 9, 2024
@juliev0
Copy link
Collaborator Author

juliev0 commented Sep 9, 2024

@chandankumar4 would you mind checking if there are other cases where we are saying some other reason than "Progressing", but it could be a progressing case?

@juliev0
Copy link
Collaborator Author

juliev0 commented Sep 11, 2024

Since some Conditions will inevitably be ambiguous, I think the way I will deal with it instead is this: once we are setting inProgressStrategy to "PPND", then I will concern myself with all unhealthy Child Conditions and not worry about their particular "Reason". I will make sure we're pausing if there's still unhealthiness during the process of PPND and not outside of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants