Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pause time metric for pipelines can distinguish whether the pausing was user-requested #240

Closed
juliev0 opened this issue Sep 10, 2024 · 2 comments · Fixed by #376
Closed
Assignees
Labels
enhancement New feature or request

Comments

@juliev0
Copy link
Collaborator

juliev0 commented Sep 10, 2024

Summary

For the total pause time metric for pipelines, it would be good if we can ultimately chart/alert on pipelines that have been paused by the system, as opposed to those that have been paused by the user.

The ones that have been paused by the user are the ones for which the Rollout's Pipeline spec indicate spec.desiredPhase=Paused.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@juliev0 juliev0 added the enhancement New feature or request label Sep 10, 2024
@juliev0
Copy link
Collaborator Author

juliev0 commented Sep 10, 2024

(note if you look for specBasedPause in pipelinerollout_controller.go, you'll see logic that's looking for this currently)

@xdevxy did you want to go into this Sprint or later in Q1?

@juliev0
Copy link
Collaborator Author

juliev0 commented Oct 27, 2024

@afugazzotto have you started working on this yet? If not, do you mind if we reassign to @dpadhiar ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants