Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if Pipeline is failed only briefly, don't simply reapply spec immediately #267

Open
juliev0 opened this issue Sep 14, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@juliev0
Copy link
Collaborator

juliev0 commented Sep 14, 2024

Describe the bug

I've noticed that if you update the ISBService, the Pipeline will momentarily indicate that it's "Failed". I'm concerned about this potential scenario:

  1. User updates both isbsvc and pipeline in github
  2. ArgoCD uses sync waves such that it will update isbsvc first
  3. isbsvc is updated, which pauses pipelines
  4. isbsvc is done, so pipelines are allowed to run
  5. pipeline is temporarily marked "Failed" because "isbsvc is unhealthy"
  6. Numaplane updates the Pipeline spec without pausing because the pipeline is technically "Failed"

Therefore, we should have a delay after which if it's still failed, we can just do the reapply.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

@juliev0 juliev0 added the bug Something isn't working label Sep 14, 2024
@juliev0 juliev0 self-assigned this Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant