[Lee Bing Heng] iP #565
Open
[Lee Bing Heng] iP #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushiyade
reviewed
Sep 8, 2023
| DEADLINE("deadline"), | ||
| EVENT("event"), | ||
| DELETE("delete"), | ||
| FIND("find"), |
There was a problem hiding this comment.
Great that you have implemented enums to keep track of the long list of keywords!
Comment on lines
+208
to
+222
| protected Response find(String keyword) throws DukeException { | ||
| ArrayList<String> output = new ArrayList<>(); | ||
| output.add("Here are the matching tasks in your list:"); | ||
|
|
||
| int count = 0; | ||
| for (Task task : this.tasks) { | ||
| if (task.name().contains(keyword)) { | ||
| output.add(String.format("%d.%s", ++count, task.toString())); | ||
| } | ||
| } | ||
| if (count == 0) { | ||
| throw new TaskNotFoundException(); | ||
| } | ||
| return Response.generate(output); | ||
| } |
suryanshkushwaha
left a comment
suryanshkushwaha
left a comment
There was a problem hiding this comment.
LGTM. Overall I feel the code is short and apt.
However, I do feel that it could be better abstracted into more packages.
src/main/java/duke/Duke.java
Outdated
| @@ -0,0 +1,10 @@ | |||
| package duke; | |||
|
|
|||
| import duke.Utils.Session; | |||
There was a problem hiding this comment.
are the packages supposed to be in lower case format?
| + ":00"; | ||
| return LocalDateTime.parse(timeSequence); | ||
| } | ||
| } No newline at end of file |
Comment on lines
1
to
30
| package duke.Utils; | ||
|
|
||
| /** | ||
| * The DukeException class is a custom runtime exception class for handling exceptions | ||
| * specific to the Duke application. | ||
| * It extends the RuntimeException class and includes a custom error message. | ||
| */ | ||
| public class DukeException extends RuntimeException { | ||
|
|
||
| private String errorMessage; | ||
|
|
||
| /** | ||
| * Constructs a new DukeException with a custom error message. | ||
| * | ||
| * @param errorMessage The custom error message to be associated with the exception. | ||
| */ | ||
| protected DukeException(String errorMessage) { | ||
| this.errorMessage = errorMessage; | ||
| } | ||
|
|
||
| /** | ||
| * Returns a string representation of the DukeException, including an error message. | ||
| * | ||
| * @return A string containing the error message preceded by "OOPS!!!". | ||
| */ | ||
| @Override | ||
| public String toString() { | ||
| return "OOPS!!! " + errorMessage; | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
How about having different package just for exceptions?
| assertThrows(InvalidArgumentException.class, () -> Command.assertDateTime(string, testCommand)); | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Great to see intensive code testing.
Comment on lines
+10
to
+13
| enum Type { | ||
| TODO("[T]", 3), | ||
| DEADLINE("[D]", 4), | ||
| EVENT("[E]", 5); |
Improved code quality
into smaller, readable, maintainable code Fixed bugs pertaining to resizing of textbox generated from Duke Added assertions in command to ensure custom assertions to be working as expected
Refactoring Session.java: Segmented initializeUI
Branch bcd extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BudgetDuke
How to use
public static void main (String[] args) { Duke.die(); }😃
My repo