[Song Bingxi] iP #581

Propene-L · 2023-09-09T06:36:30Z

Veneto

“Your mind is for having ideas, not holding them.” – David Allen source

Veneto frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines
Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

zacwong2151

Looks good to me except for some parts

everything should be written in English!
some parts could be extracted out into Ui, Parser classes
do consider adding a description for your PR!

zacwong2151 · 2023-09-09T13:51:42Z

src/main/java/Dan.java

+public class Dan {
+
+    private final static String greets = "\nDan: \n";
+    private static MyList tasks = new MyList(100);


perhaps a class name like TaskList would be more intuitive than MyList?

zacwong2151 · 2023-09-09T13:52:25Z

src/main/java/Dan.java

+        System.out.println(
+                greets +
+                " 好啦，帮你擦掉了一条任务哦：\n " + removedTask +
+                "\n 现在还剩下" + tasks.size() + "项任务哦！\n"


only english is recommended for coding!

zacwong2151 · 2023-09-09T13:53:00Z

src/main/java/Dan.java

+import java.util.Arrays;
+import java.util.Scanner;
+
+enum TASK_TYPE {TODO, DEADLINE, EVENT}


Good job on setting your ToDos as enums!

zacwong2151 · 2023-09-09T13:54:45Z

src/main/java/Dan.java

+            command = texts[0].toLowerCase();
+            switch (command) {
+                case "bye":
+                    break a;


perhaps it would be better if you can extract these 'instructions' out to a Ui class

zacwong2151 · 2023-09-09T13:57:41Z

src/main/java/Dan.java

+            try {
+            text = new Scanner(System.in).nextLine();
+            texts = text.split(" ");
+            command = texts[0].toLowerCase();


can consider extracting the commands to a Parser or Command class

starrylight99

pokemon exception, try to be more specific in catching your exceptions :)

renaming filePath to storagePath in Veneto.

added markTask() and unmarkTask() to avoid deep nesting and improved readability

added EXIT_SUFFIX to show operated command is ExitCommand added INCORRECT_ERROR to show unidentified error modifed COMMAND and make it looks better added three methods to improve readability added showOperationError() to deal with VenetoOperationException added showStorageError() to deal with VenetoStorageException added showInvalidError() to deal with unexpected exceptions

merging A-codequality to master

# Conflicts: # src/main/java/veneto/Veneto.java # src/main/java/veneto/ui/Ui.java Conflicts resolved

…askList

Ui.png

damithc and others added 22 commits August 9, 2023 02:16

Add Gradle support

28ad2b8

Bump gradle and lib version

ed6d4d2

add level-0

d70a89c

added Level 1

fb563f9

add MyList.java

73ab967

added level 2

6fabf95

add Task.java

ab634e9

changing MyList to a Task List

0443851

added level 3

03e576d

add Deadline.java

2dddc56

add Event.java

da7ab38

add toDo.java

0d3fb8f

add some comments to Task.java

71a526c

modified MyList.java

32d61ff

added level 4

c2dd4b6

bug fixed

7bb853f

added DanException

946a420

add level 5

f3c38a1

added level 6

af19be1

used enums

6e02da2

bug fixed after using enums

83987f8

input.txt modified

6940826

zacwong2151 reviewed Sep 9, 2023

View reviewed changes

starrylight99 reviewed Sep 9, 2023

View reviewed changes

Propene-L added 6 commits September 10, 2023 14:49

updated deadline.java with functions

fe6a5b7

updated event.java with funcs

9de4371

updated task.java with funcs

610f3fe

updated todo.java with functions

31194bf

updated test-ui-test

12dd515

add level 7

886b3f9

Propene-L and others added 30 commits September 28, 2023 22:13

added Main.java

52a9a05

added Launcher

2e83549

changed Veneto: chat() -> getResponse()

0805e76

modified Ui

4ae78e2

Merge branch 'level-10'

3768770

added a new jar file

6e0c6ee

Renaming fields to improve code quality.

78e06a8

renaming filePath to storagePath in Veneto.

removed redundant try-catch to improve readability

effae22

modified mark() in Task.java

85b5fe1

added markTask() and unmarkTask() to avoid deep nesting and improved readability

fixed bugs in MainWindow.java

e9d938d

Merge pull request #2 from Propene-Dan/A-CodeQuality

d0b01b6

merging A-codequality to master

enable assertions

b3d12f6

added constants STORAGE_DIR and STORAGE_PATH in Storage.java

7c31503

added assertion for invariants in Parser

f5ceeda

added assertion for invariants in Storage

a3a41f8

added assertion for invariants in Ui

45a6206

Merge branch 'A-Assertions'

a5029d5

# Conflicts: # src/main/java/veneto/Veneto.java # src/main/java/veneto/ui/Ui.java Conflicts resolved

modified type of VenetoStorageException when no storage found

f0d90f6

added isDuplicated() to check duplicate task when adding newTask to T…

abbd6f3

…askList

added javaDoc to AddCommand.java

3cbd8d8

added equals() to Task.java

7d35804

added equals() to ToDo.java

75c053e

added equals() and detect DateTimeParseException to Deadline.java

84f331d

added equals() and detect DateTimeParseException to Event.java

f4321f0

catch DateTimeParseException in Parser.java

8b9f254

add response when found duplicates

b31387c

Merge branch 'C-DetectDuplicates'

82e28de

Add files via upload

0ad66b8

Ui.png

Update README.md

e0e610e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Song Bingxi] iP #581

[Song Bingxi] iP #581

Uh oh!

Propene-L commented Sep 9, 2023 •

edited

Loading

Uh oh!

zacwong2151 left a comment •

edited

Loading

Uh oh!

zacwong2151 Sep 9, 2023

Uh oh!

zacwong2151 Sep 9, 2023

Uh oh!

zacwong2151 Sep 9, 2023

Uh oh!

zacwong2151 Sep 9, 2023

Uh oh!

zacwong2151 Sep 9, 2023

Uh oh!

starrylight99 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

[Song Bingxi] iP #581

Are you sure you want to change the base?

[Song Bingxi] iP #581

Uh oh!

Conversation

Propene-L commented Sep 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Veneto

Uh oh!

zacwong2151 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zacwong2151 Sep 9, 2023

Choose a reason for hiding this comment

Uh oh!

zacwong2151 Sep 9, 2023

Choose a reason for hiding this comment

Uh oh!

zacwong2151 Sep 9, 2023

Choose a reason for hiding this comment

Uh oh!

zacwong2151 Sep 9, 2023

Choose a reason for hiding this comment

Uh oh!

zacwong2151 Sep 9, 2023

Choose a reason for hiding this comment

Uh oh!

starrylight99 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Propene-L commented Sep 9, 2023 •

edited

Loading

zacwong2151 left a comment •

edited

Loading