-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maybe dropping thecodingmachine/safe
as a dependency
#2649
Comments
The package actually seems to be picking up steam again lately, see thecodingmachine/safe#499. I do see the value in minimizing dependencies regardless. The usages in this library are somewhat limited, so I definitely see it as something realistic. However, wouldn't we need to get rid of the transitive dependency in all other packages too to realize the benefit? |
You are right of course but it seems like this might be do-able. It's not used in a third party dependency as far as I can tell (as in you are maintainer in all of them except the phpstan rule which can be dropped):
We can also postpone this to see what the rekindled effort might do of course. |
thecodingmachine 3.0.0 has fixed the php 8.4 compatibility, but this needs a fix in composer.json |
Awesome! This looks like a easy constraint to bump, good work! |
I am working on updating the constraint in the dependencies. |
I have begun work on #2657. |
Thank you very much for the hard work! My console thanks you very much! 🧡 |
Lighthouse (and
laragraph/utils
,mll-lab/graphql-php-scalars
and possibly others) are requiringthecodingmachine/safe
as a dependency. However this project does not seem to be maintained (anymore) and its benefit also not that great anymore. The biggest issue is that it't not 8.4 compatible causing a lot of deprecation notices, although silence able I wonder if we could just remove the dependency altogether?From what I can tell at least in this project most of it's usage is around testing and most other code might need a few extra lines to throw on an error themself but seems do-able.
Search for usage: https://github.com/search?q=repo%3Anuwave%2Flighthouse+%22Safe%5C%5C%22&type=code&p=1
WDYT?
The text was updated successfully, but these errors were encountered: