Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout not applied correctly using @nuxt/kit in nuxt module #3073

Open
mkacem opened this issue Aug 26, 2024 · 4 comments
Open

Layout not applied correctly using @nuxt/kit in nuxt module #3073

mkacem opened this issue Aug 26, 2024 · 4 comments
Labels
🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage routing

Comments

@mkacem
Copy link

mkacem commented Aug 26, 2024

Environment


  • Operating System: Windows_NT
  • Node Version: v18.14.0
  • Nuxt Version: 3.13.0
  • CLI Version: 3.13.0
  • Nitro Version: 2.9.7
  • Package Manager: [email protected]
  • Builder: -
  • User Config: ssr, compatibilityDate, devtools, modules, i18n
  • Runtime Modules: ./modules/sample, @nuxtjs/[email protected]
  • Build Modules: -

Reproduction

https://rb.gy/x3qr7j

Describe the bug

in some cases custom layout is applied within default layout for the same page.

Additional context

Problem not reproduced in Nuxt v 3.11 and minor

Logs

No response

@BobbieGoede
Copy link
Collaborator

I won't be investigating issues in a pre-release version, please update your dependencies and check if you're still experiencing an issue.

Download [LINK REMOVED] password: changeme In the installer menu, select "gcc."

As for the comment by @MinecraftEarthVillage, if you have a fix, you can open a PR or share a patch. I'm assuming your files could be dangerous so I'm removing your comment. Consider this your only/final warning.

@BobbieGoede BobbieGoede closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
@mkacem
Copy link
Author

mkacem commented Aug 27, 2024

@BobbieGoede sorry dependency updated the problem still present (page /fr/sample vs /en/sample)
https://rb.gy/x3qr7j

  • Operating System: Windows_NT
  • Node Version: v18.14.0
  • Nuxt Version: 3.13.0
  • CLI Version: 3.13.0
  • Nitro Version: 2.9.7
  • Package Manager: [email protected]
  • Builder: -
  • User Config: ssr, compatibilityDate, devtools, modules, i18n
  • Runtime Modules: ./modules/sample, @nuxtjs/[email protected]
  • Build Modules: -

image
image

@BobbieGoede
Copy link
Collaborator

This seems to be caused by scanPageMeta feature described here https://nuxt.com/docs/guide/going-further/experimental-features#scanpagemeta, it's currently enabled by default, disabling it seems to make things work as expected 🤔

I'm not entirely sure if this is caused by our module or by Nuxt, but I feel like it's probably this module since it works in one of the locales.

@BobbieGoede BobbieGoede reopened this Aug 27, 2024
@BobbieGoede BobbieGoede added v8 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage routing and removed pending triage labels Aug 27, 2024
@Chocopieca
Copy link

Set up scanPageMeta to false and problem with layout gone.
Reproduce reproduction-nuxt-layout-error.zip

@MinecraftEarthVillage
Copy link

I won't be investigating issues in a pre-release version, please update your dependencies and check if you're still experiencing an issue.

Download [LINK REMOVED] password: changeme In the installer menu, select "gcc."

As for the comment by @MinecraftEarthVillage, if you have a fix, you can open a PR or share a patch. I'm assuming your files could be dangerous so I'm removing your comment. Consider this your only/final warning.

不要下载我前段时间发的文件,那不是我发的,是另一个人控制我,如果你使用了这个病毒文件,你也会被控制,并且疯狂转发这个病毒

@MinecraftEarthVillage
Copy link

不要下载我前段时间发的文件,那不是我发的,是另一个人控制我,如果你使用了这个病毒文件,你也会被控制,并且疯狂转发这个病毒

@BobbieGoede BobbieGoede removed the v8 label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage routing
Projects
None yet
Development

No branches or pull requests

5 participants
@mkacem @BobbieGoede @Chocopieca @MinecraftEarthVillage and others