Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invisible user card data on Safari (viewport > 10xx width) #85

Closed
wants to merge 1 commit into from

Conversation

meduzen
Copy link

@meduzen meduzen commented Aug 29, 2024

πŸ”— Linked issue

Closes #84.

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)

πŸ“š Description

On Safari macOS, turns screenshot 1 into screenshot 2. πŸ‘‡

(Look near the footer area.)

View screenshot 1
View screenshot 2

It should not have any side-effect, but considering the messy styles architecture Tailwind encourages, I can’t guarantee it 100%. I did not check how to be able to run the project locally without the proper .env variables.

@danielroe danielroe requested a review from arashsheyda March 10, 2025 10:04
@arashsheyda
Copy link
Member

@meduzen ^sorry for the late reply, and thanks

I'm not able to reproduce the bug, and I can't see a problem with your current change, but I can guide thru how to run the project locally (you can even open a PR to document that for others) and see if that fixes your problem. thanks

  1. install dependencies (pnpm install)
  2. copy the .env.example and rename it to .env
  3. you have to fill NUXT_SESSION_PASSWORD with 32 character length e.g. 0E0Sv4PwlKU4akT2nYjElg0Tl4svD7KF
  4. pnpm dev to run the project

let me know if you have any questions. thanks for working on this!

@meduzen
Copy link
Author

meduzen commented Mar 25, 2025

Hi @arashsheyda! I’m not able to reproduce anymore, now using Safari macOS 18 (bug happened on Safari 17), so I guess this PR is not useful anymore.

Closing it and the related issue.

@arashsheyda
Copy link
Member

thank you @meduzen . would you like to update the readme about how to run the project if you think it's not clear? thanks

@meduzen
Copy link
Author

meduzen commented Mar 26, 2025

I leave this to another contributor, since my bandwidth is focused on other things these days.

Thanks for the suggestion, thou, it’s nice to invite for contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invisible user card data on Safari (viewport > 10xx width)
2 participants