Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs warning Computed is still dirty after getter evaluation #1392

Closed
ThomasWT opened this issue Feb 21, 2024 · 3 comments
Closed

Tabs warning Computed is still dirty after getter evaluation #1392

ThomasWT opened this issue Feb 21, 2024 · 3 comments
Labels
bug Something isn't working upstream

Comments

@ThomasWT
Copy link

Environment

  • Operating System: Linux
  • Node Version: v18.18.0
  • Nuxt Version: 3.10.2
  • CLI Version: 3.10.1
  • Nitro Version: 2.8.1
  • Package Manager: [email protected]
  • Builder: -
  • User Config: devtools, modules
  • Runtime Modules: @nuxt/[email protected]
  • Build Modules: -

Version

v2.13.0

Reproduction

https://stackblitz.com/edit/nuxt-starter-d5gcpn

Description

Using the tabs component throws a warning in the console, client side seeming to slow down the clientside hydration

vue.js:288 [Vue warn] Computed is still dirty after getter evaluation, likely because a computed is mutating its own dependency in its getter. State mutations in computed getters should be avoided. Check the docs for more details: https://vuejs.org/guide/essentials/computed.html#getters-should-be-side-effect-free

Additional context

No response

Logs

vue.js:288 [Vue warn] Computed is still dirty after getter evaluation, likely because a computed is mutating its own dependency in its getter. State mutations in computed getters should be avoided.  Check the docs for more details: https://vuejs.org/guide/essentials/computed.html#getters-should-be-side-effect-free
@ThomasWT ThomasWT added the bug Something isn't working label Feb 21, 2024
Copy link
Member

This is a warning that was added in Vue v3.4.19, and an issue has already been created in Headless UI: tailwindlabs/headlessui#2985. We cannot do much about it but to wait for a fix in Headless UI.

@GalacticHypernova
Copy link

@benjamincanac does this mean this can be closed with the release of V3 soon?

Copy link
Member

I guess so as we don't have control over this since it's related to Headless UI!

@benjamincanac benjamincanac closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

3 participants