fixes to localnet purge

Author: jstuczyn

tools/internal/localnet-orchestrator/src/cli/purge.rs

@@ -4,6 +4,7 @@
 use crate::cli::CommonArgs;
 use crate::orchestrator::LocalnetOrchestrator;
 use crate::orchestrator::setup::purge;
+use clap::ArgAction;
 use std::path::PathBuf;
 use tracing::debug;
 
@@ -13,11 +14,11 @@ pub(crate) struct Args {
     common: CommonArgs,
 
     /// Remove any built docker and container images
-    #[clap(long, default_value_t = true)]
+    #[clap(long, action = ArgAction::Set, default_value_t = true)]
     remove_images: bool,
 
     /// Remove any cached build data
-    #[clap(long, default_value_t = true)]
+    #[clap(long, action = ArgAction::Set, default_value_t = true)]
     remove_cache: bool,
 
     /// Custom path to root of the monorepo in case this binary has been executed from a different location.

tools/internal/localnet-orchestrator/src/orchestrator/setup/purge.rs

@@ -1,13 +1,13 @@
 // Copyright 2025 - Nym Technologies SA <[email protected]>
 // SPDX-License-Identifier: Apache-2.0
 
-use crate::constants::LOCALNET_NYXD_IMAGE_NAME;
 use crate::helpers::monorepo_root_path;
 use crate::orchestrator::LocalnetOrchestrator;
 use crate::orchestrator::container_helpers::{
     default_nym_binaries_image_tag, remove_container_image,
 };
 use crate::orchestrator::context::LocalnetContext;
+use anyhow::Context;
 use std::path::PathBuf;
 
 struct LocalnetPurge {
@@ -41,12 +41,16 @@ impl LocalnetOrchestrator {
     ) -> anyhow::Result<()> {
         ctx.begin_next_step("removing all built images", "🔥");
         if !ctx.data.remove_images {
-            ctx.println("\t NOT ENABLED - SKIPPING")
+            ctx.println("\t NOT ENABLED - SKIPPING");
+            return Ok(());
         }
 
         let nym_binaries_tag = default_nym_binaries_image_tag(&ctx.data.monorepo_root)?;
 
-        for tag in [nym_binaries_tag, LOCALNET_NYXD_IMAGE_NAME.to_string()] {
+        // TODO: we need to dynamically determine tag for this
+        // LOCALNET_NYXD_IMAGE_NAME.to_string()
+
+        for tag in [nym_binaries_tag] {
             ctx.execute_cmd_with_stdout("docker", ["image", "rm", &tag])
                 .await?;
             remove_container_image(ctx, &tag).await?;
@@ -58,7 +62,8 @@ impl LocalnetOrchestrator {
     fn remove_build_cache(&self, ctx: &mut LocalnetContext<LocalnetPurge>) -> anyhow::Result<()> {
         ctx.begin_next_step("removing build cache", "🔥");
         if !ctx.data.remove_cache {
-            ctx.println("\t NOT ENABLED - SKIPPING")
+            ctx.println("\t NOT ENABLED - SKIPPING");
+            return Ok(());
         }
 
         self.storage.data_cache().clear()
@@ -70,17 +75,18 @@ impl LocalnetOrchestrator {
     ) -> anyhow::Result<()> {
         ctx.begin_next_step("removing storage data", "🔥");
 
-        std::fs::remove_dir_all(self.storage.localnet_directory())?;
+        std::fs::remove_dir_all(self.storage.localnet_directory())
+            .context("missing main storage directory")?;
         let storage_db = self.storage.into_orchestrator_storage();
         let db_path = storage_db.stop().await?;
-        std::fs::remove_dir_all(db_path)?;
+        std::fs::remove_file(db_path).context("missing database path")?;
 
         Ok(())
     }
 
     pub(crate) async fn purge_localnet(self, config: Config) -> anyhow::Result<()> {
         let purge = LocalnetPurge::new(config)?;
-        let mut ctx = LocalnetContext::new(purge, 4, "\npurging localnet");
+        let mut ctx = LocalnetContext::new(purge, 3, "\npurging localnet");
 
         // 1. stop the localnet
         self.stop_localnet().await?;

tools/internal/localnet-orchestrator/src/serde_helpers/linux.rs

@@ -84,6 +84,7 @@ impl TryFrom<ContainersList> for super::ContainersList {
             containers: value
                 .0
                 .into_iter()
+                .filter(|c| c.names.contains("localnet"))
                 .map(TryInto::try_into)
                 .collect::<anyhow::Result<Vec<_>>>()?,
         })

tools/internal/localnet-orchestrator/src/serde_helpers/macos.rs

@@ -18,6 +18,7 @@ impl TryFrom<ContainersList> for super::ContainersList {
             containers: value
                 .0
                 .into_iter()
+                .filter(|c| c.configuration.id.contains("localnet"))
                 .map(TryInto::try_into)
                 .collect::<anyhow::Result<Vec<_>>>()?,
         })
@@ -138,12 +139,23 @@ pub struct ContainerNetwork {
 impl TryFrom<ContainerInformation> for PlaceholderCommonContainerInformation {
     type Error = anyhow::Error;
 
+    #[track_caller]
     fn try_from(value: ContainerInformation) -> Result<Self, Self::Error> {
+        let status = value.status.to_lowercase();
+        let ip_address = if status == "running" {
+            Some(value.container_ip().context(format!(
+                "invalid container {} ({})",
+                value.configuration.id, value.configuration.image.reference
+            ))?)
+        } else {
+            None
+        };
+
         Ok(PlaceholderCommonContainerInformation {
-            ip_address: Some(value.container_ip()?),
+            ip_address,
             name: value.configuration.id,
             image: value.configuration.image.reference,
-            status: value.status.to_lowercase(),
+            status,
         })
     }
 }