Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Bible Verse Quicklook 🔍 #4163

Closed
wants to merge 2 commits into from

Conversation

joeriddles
Copy link
Contributor

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/joeriddles/bible-verse-quicklook

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
  • I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add joeriddles/bible-verse-quicklook to community-plugins.json Add plugin: Bible Verse Quicklook 🔍 Sep 3, 2024
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3]:Using innerHTML, outerHTML or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements

[1][2]:You should not cast this, instead use a instanceof check to make sure that it's actually a file/folder.


Optional

[1]:Casting to any should be avoided as much as possible.

[1]:Obsidian provides the requestUrl method, it will make sure that network requests work on every plattform.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this Sep 4, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Sep 4, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 1.0.5. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@joeriddles joeriddles closed this Sep 10, 2024
@joeriddles joeriddles reopened this Sep 10, 2024
@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Sep 11, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment Sep 11, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented Sep 19, 2024

"name": "Bible Verse Quicklook 🔍",
Please remove the emoji, plugin names should not have emoji's included.
It causes issues in some systems.

const onmouseover = `
Please register this as an event, and not write the JS as inline code.

const response = await fetch(https://bible-api.com/${verse.book} ${verse.chapter}:${verse.verseStart})
Use the requestUrl function from the Obsidian API instead, it will handle some things like CORS automatically.

getLookVerseString(verse: Verse): string {
This method should not exist.

this.containerEl.createEl("h2", { text: "Bible Verse Quicklook" });
Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.

.setName('API.Bible Key')
Wrong text, also, please include some information in your README that this service is being used and how to acquire and API key

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Sep 19, 2024
Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

@github-actions github-actions bot added the stale label Oct 20, 2024
Copy link

github-actions bot commented Nov 4, 2024

Hi there, to keep things tidy, we're closing PRs after one and a half months of inactivity.
Feel free to create a new pull request when you're ready to continue. Thanks for your understanding!

@github-actions github-actions bot closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants