Add plugin: Yesterday's note

[trevortylerlee]

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/trevortylerlee/yesterdays-note

Release Checklist

• I have tested the plugin on
  • Windows
  • macOS
  • Linux
  • Android (if applicable)
  • iOS (if applicable)
• My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
  • main.js
  • manifest.json
  • styles.css (optional)
• GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• The id in my manifest.json matches the id in the community-plugins.json file.
• My README.md describes the plugin's purpose and provides clear usage instructions.
• I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
• I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
• I have added a license in the LICENSE file.
• My project respects and is compatible with the original license of any code from other plugins that I'm using.
  I have given proper attribution to these other projects in my README.md.

[ObsidianReviewBot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2]:You should not cast this, instead use a instanceof check to make sure that it's actually a file/folder.

---

Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

[trevortylerlee]

I've refactored the code to use the instanceof check to validate if the file/folder exists.

[ObsidianReviewBot]

Changes requested by bot have been made, ready for additional review by human.

[Zachatoo]

"fundingUrl": "https://trevortylerlee.com",
This is meant for links to services like Buy me a coffee, GitHub sponsors and so on, if you don't have such a link remove this line.

return await this.app.vault.read(templateFile);
Prefer to use Vault.cachedRead() over Vault.read() when you aren't going to be modifying the file

const leaf = this.app.workspace.getUnpinnedLeaf();
Prefer to not use deprecated APIs. Please use getLeaf(false) instead.

---

Is there an expected use case for the Daily Note settings and your plugin's settings to differ? For example, for the Daily Note's date format and your plugin's date format setting to be different? I would recommend either removing settings from your plugin that can be inherited from the Daily Notes plugin settings, or adding a description to each setting that defaults to the Daily Note plugin settings to make it clear that it will inherit the Daily Note plugin setting, and that the user does not need to fill out that setting.

[trevortylerlee]

Thanks for the feedback, made the following changes:

• use Vault.cachedRead() instead of Vault.read()
• use getLeaf(false) instead of getUnpinnedLeaf()
• remove unnecessary settings and use default Daily note settings
  • remove custom date format
  • remove custom note location
  • remove custom template

[ObsidianReviewBot]

Changes requested by Zachatoo have been made, assigning additional human for additional review

[joethei]

Please remove the "Obsidian" branding from the image in your README, that makes it look like this is an official product.

[trevortylerlee]

Done.

[trevortylerlee]

@joethei Changes have been made, can you take another look?