Skip to content

Contributor frontend 4#10

Merged
SKairinos merged 15 commits into
developmentfrom
contributor-frontend-4
Sep 17, 2024
Merged

Contributor frontend 4#10
SKairinos merged 15 commits into
developmentfrom
contributor-frontend-4

Conversation

@SKairinos

@SKairinos SKairinos commented Sep 13, 2024

Copy link
Copy Markdown
Contributor

This change is Reviewable

@SKairinos SKairinos linked an issue Sep 13, 2024 that may be closed by this pull request

@faucomte97 faucomte97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 15 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)


src/pages/agreementSignatures/SignLatestAgreementForm.tsx line 60 at r2 (raw file):

                  >
                    latest agreement
                  </Link>

It's a bit mouthier but let's say "I have read, understood and agreed to the terms of the latest agreement."

Code quote:

                  I have read and understood the{" "}
                  <Link
                    to={LINK_GH_CONTRIBUTING.replace("{commitId}", agreementId)}
                    target="_blank"
                  >
                    latest agreement
                  </Link>

@faucomte97 faucomte97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit 1ae9d5f into development Sep 17, 2024
@SKairinos SKairinos deleted the contributor-frontend-4 branch September 17, 2024 13:04
@ghost

ghost commented Dec 13, 2024

Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ghost ghost added the released label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

agreement signatures page

2 participants