Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scalar types use explicit any, but their types are known #560

Open
jbreckel opened this issue Nov 29, 2021 · 1 comment · Fixed by zhouzi/github-graphql-schema#3
Open

Scalar types use explicit any, but their types are known #560

jbreckel opened this issue Nov 29, 2021 · 1 comment · Fixed by zhouzi/github-graphql-schema#3
Labels
Type: Feature New feature or request

Comments

@jbreckel
Copy link

The currently used custom scalar types are all strings, as noted in the comments.

Using unknown instead of any would also be the type safe way as described here.
@jbreckel jbreckel mentioned this issue Nov 29, 2021
Closed
@wolfy1339 wolfy1339 added the Type: Feature New feature or request label Nov 29, 2021
@zhouzi zhouzi mentioned this issue May 19, 2022
Merged
@zhouzi
Copy link

zhouzi commented May 19, 2022

The fix proposed to this issue in #561 is part of my fork which is also published to npm, with automatic updates enabled:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add types for known scalars zhouzi/github-graphql-schema
feat: add types for known scalars
3 participants
@zhouzi @wolfy1339 @jbreckel