[IMP] hr_skills : manager are able to see his subordinates's skill's history

With this commit, even if you don't have right in Employee application,
you are able to see your subordinates's skill's history. This improvment
will help manager to have a better idea of his subordinates's improvment.

closes odoo#158525

Task: 3792519
Signed-off-by: Bertrand Dossogne (bedo) <[email protected]>

Author: mepe-odoo

addons/hr_skills/security/hr_skills_security.xml

@@ -51,6 +51,20 @@
         <field name="groups" eval="[(4,ref('base.group_user'))]"/>
     </record>
 
+    <record id="hr_employee_skill_log_hr_user_rule" model="ir.rule">
+        <field name="name">Employee Skill History: HR user : read all</field>
+        <field name="model_id" ref="model_hr_employee_skill_log"/>
+        <field name="domain_force">[(1, '=', 1)]</field>
+        <field name="groups" eval="[(4, ref('hr.group_hr_user'))]"/>
+    </record>
+
+    <record id="hr_employee_skill_log_manager_rule" model="ir.rule">
+        <field name="name">Employee Skill History: employee's manager : read all</field>
+        <field name="model_id" ref="model_hr_employee_skill_log"/>
+        <field name="domain_force">[('employee_id.id', 'child_of', user.employee_ids.ids)]</field>
+        <field name="groups" eval="[(4, ref('base.group_user'))]"/>
+    </record>
+
     <record id="hr_employee_skill_report_multicompany" model="ir.rule">
         <field name="name">Employee Skill Report: Multi-Company Rule</field>
         <field name="model_id" ref="model_hr_employee_skill_report"/>

addons/hr_skills/security/ir.model.access.csv

@@ -13,4 +13,5 @@ access_hr_employee_skill,hr.employee.skill,model_hr_employee_skill,hr.group_hr_u
 access_hr_employee_skill_employee,hr.employee.skill,model_hr_employee_skill,base.group_user,1,1,1,1
 access_hr_employee_skill_report,hr.employee.skill.report,model_hr_employee_skill_report,hr.group_hr_user,1,0,0,0
 access_hr_employee_skill_log,hr.employee.skill.log,model_hr_employee_skill_log,hr.group_hr_user,1,1,1,0
+access_hr_employee_skill_log_manager,hr.employee.skill.log,model_hr_employee_skill_log,base.group_user,1,0,0,0
 access_hr_employee_cv_wizard,access_hr_employee_cv_wizard,hr_skills.model_hr_employee_cv_wizard,base.group_user,1,1,1,0

addons/hr_skills/static/src/fields/skills_one2many/skills_one2many.js

@@ -7,6 +7,7 @@ import {
 } from "@web/views/fields/relational_utils";
 import { registry } from "@web/core/registry";
 import { _t } from "@web/core/l10n/translation";
+import { user } from "@web/core/user";
 import { CommonSkillsListRenderer } from "../../views/skills_list_renderer";
 import { useService } from '@web/core/utils/hooks';
 import { onWillStart } from "@odoo/owl";
@@ -22,6 +23,13 @@ export class SkillsListRenderer extends CommonSkillsListRenderer {
         onWillStart(async () => {
             const res = await this.orm.searchCount('hr.skill', []);
             this.anySkills = res > 0;
+            [this.user] = await this.orm.read("res.users", [user.userId], ["employee_ids"]);
+            this.IsHrUser = await user.hasGroup("hr.group_hr_user");
+            this.userSubordinates = (await this.orm.searchRead(
+                "hr.employee",
+                [["id", "child_of", this.user.employee_ids]],
+                ["id"]
+            )).map((record) => record["id"]);
         });
     }
 
@@ -62,7 +70,15 @@ export class SkillsListRenderer extends CommonSkillsListRenderer {
     }
 
     get showTimeline() {
-        return !this.props.list.context.no_timeline;
+        return this.SkillsRight && !this.props.list.context.no_timeline;
+    }
+
+    get SkillsRight() {
+        let isSubordinate = false;
+        if (this.env.model.root.data.employee_id) {
+            isSubordinate = this.userSubordinates.includes(this.env.model.root.data.employee_id[0]);
+        }
+        return this.IsHrUser || isSubordinate;
     }
 }