Skip to content

Commit 3d13a95

Browse files
committed
[IMP] website: adapt snippet_popup_and_scrollbar tour
1 parent 7814e25 commit 3d13a95

File tree

2 files changed

+24
-23
lines changed

2 files changed

+24
-23
lines changed

addons/website/static/tests/tours/snippet_popup_and_scrollbar.js

+18-21
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ const checkScrollbar = function (hasScrollbar) {
3333
};
3434
};
3535

36-
const toggleBackdrop = function () {
37-
return changeOption('SnippetPopup', 'we-button[data-name="popup_backdrop_opt"] we-checkbox', 'backdrop');
36+
const toggleBackdrop = function (snippet) {
37+
return changeOption(snippet, '.o-checkbox input');
3838
};
3939

4040
registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
@@ -49,17 +49,17 @@ registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
4949
trigger: ':iframe .s_popup .modal',
5050
run: "click",
5151
},
52-
toggleBackdrop(), // hide Popup backdrop
52+
toggleBackdrop("Popup"), // hide Popup backdrop
5353
checkScrollbar(true),
5454
goBackToBlocks(),
5555
{
5656
content: "Drag the Content snippet group and drop it at the bottom of the popup.",
57-
trigger: '#oe_snippets .oe_snippet[name="Content"] .oe_snippet_thumbnail:not(.o_we_ongoing_insertion)',
57+
trigger: '.o-snippets-menu .o_snippet[name="Content"] .o_snippet_thumbnail:not(.o_we_ongoing_insertion)',
5858
run: "drag_and_drop :iframe #wrap .s_popup .oe_drop_zone:last",
5959
},
6060
{
6161
content: "Click on the s_media_list snippet.",
62-
trigger: ':iframe .o_snippet_preview_wrap[data-snippet-id="s_media_list"]',
62+
trigger: ':iframe .o_add_snippets_preview [data-snippet="s_media_list"]',
6363
run: "click",
6464
},
6565
checkScrollbar(false),
@@ -70,11 +70,11 @@ registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
7070
},
7171
{
7272
content: "Remove the Media List snippet in the Popup.",
73-
trigger: ":iframe .oe_overlay.oe_active .oe_snippet_remove",
73+
trigger: "body .o_overlay_options .oe_snippet_remove",
7474
run: "click",
7575
},
7676
checkScrollbar(true),
77-
toggleBackdrop(), // show Popup backdrop
77+
toggleBackdrop("Popup"), // show Popup backdrop
7878
checkScrollbar(false),
7979
{
8080
content: "Close the Popup that has now backdrop.",
@@ -88,9 +88,9 @@ registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
8888
run: "click",
8989
},
9090
checkScrollbar(true),
91-
toggleBackdrop(), // show Cookies Bar backdrop
91+
toggleBackdrop("Cookies Bar"), // show Cookies Bar backdrop
9292
checkScrollbar(false),
93-
toggleBackdrop(), // hide Cookies Bar backdrop
93+
toggleBackdrop("Cookies Bar"), // hide Cookies Bar backdrop
9494
checkScrollbar(true),
9595
{
9696
content: "Open the Popup that has backdrop.",
@@ -103,12 +103,12 @@ registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
103103
goBackToBlocks(),
104104
{
105105
content: "Drag the Content snippet group and drop it at the bottom of the popup.",
106-
trigger: '#oe_snippets .oe_snippet[name="Content"] .oe_snippet_thumbnail:not(.o_we_ongoing_insertion)',
106+
trigger: '.o-snippets-menu .o_snippet[name="Content"] .o_snippet_thumbnail:not(.o_we_ongoing_insertion)',
107107
run: "drag_and_drop :iframe #wrap .s_popup .oe_drop_zone:last",
108108
},
109109
{
110110
content: "Click on the s_media_list snippet.",
111-
trigger: ':iframe .o_snippet_preview_wrap[data-snippet-id="s_media_list"]',
111+
trigger: ':iframe .o_add_snippets_preview [data-snippet="s_media_list"]',
112112
run: "click",
113113
},
114114
/* task-4185877
@@ -121,7 +121,7 @@ registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
121121
},
122122
{
123123
content: "Remove the s_popup snippet",
124-
trigger: ".o_we_customize_panel we-customizeblock-options:contains('Popup') we-button.oe_snippet_remove:first",
124+
trigger: ".o_customize_tab .options-container[data-container-title='Popup'] .oe_snippet_remove",
125125
async run(helpers) {
126126
await helpers.click();
127127
// TODO: remove the below setTimeout. Without it, goBackToBlocks() not works.
@@ -132,12 +132,12 @@ registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
132132
goBackToBlocks(),
133133
{
134134
content: "Drag the Content snippet group and drop it in the Cookies Bar.",
135-
trigger: '#oe_snippets .oe_snippet[name="Content"] .oe_snippet_thumbnail:not(.o_we_ongoing_insertion)',
135+
trigger: '.o-snippets-menu .o_snippet[name="Content"] .o_snippet_thumbnail:not(.o_we_ongoing_insertion)',
136136
run: "drag_and_drop :iframe #website_cookies_bar .modal-content.oe_structure",
137137
},
138138
{
139139
content: "Click on the s_media_list snippet.",
140-
trigger: ':iframe .o_snippet_preview_wrap[data-snippet-id="s_media_list"]',
140+
trigger: ':iframe .o_add_snippets_preview [data-snippet="s_media_list"]',
141141
run: "click",
142142
},
143143
{
@@ -147,21 +147,18 @@ registerWebsitePreviewTour("snippet_popup_and_scrollbar", {
147147
},
148148
{
149149
content: "Duplicate the Media List snippet",
150-
trigger: ".o_we_customize_panel we-customizeblock-options:contains('Media List') we-button.oe_snippet_clone:first",
151-
run() {
152-
// TODO: use run: "click", instead
153-
this.anchor.click();
154-
}
150+
trigger:".o_customize_tab .options-container[data-container-title='Media List'] button.oe_snippet_clone",
151+
run: "click",
155152
},
156153
checkScrollbar(false),
157154
{
158155
content: "Remove the first Media List snippet in the Cookies Bar.",
159-
trigger: ":iframe .oe_overlay.oe_active .oe_snippet_remove",
156+
trigger: "body .o_overlay_options .oe_snippet_remove",
160157
run: "click",
161158
},
162159
{
163160
content: "Remove the second Media List snippet in the Cookies Bar.",
164-
trigger: ":iframe .oe_overlay.oe_active .oe_snippet_remove",
161+
trigger: "body .o_overlay_options .oe_snippet_remove",
165162
run: "click",
166163
},
167164
checkScrollbar(true),

addons/website/tests/test_snippets.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -116,11 +116,15 @@ def test_11_snippet_popup_display_on_click(self):
116116
def test_12_snippet_images_wall(self):
117117
self.start_tour('/', 'snippet_images_wall', login='admin')
118118

119-
@unittest.skip
120-
def test_snippet_popup_with_scrollbar_and_animations(self):
119+
def test_snippet_popup_with_scrollbar(self):
121120
website = self.env.ref('website.default_website')
122121
website.cookies_bar = True
123122
self.start_tour(self.env['website'].get_client_action_url('/'), 'snippet_popup_and_scrollbar', login='admin')
123+
124+
@unittest.skip
125+
def test_snippet_popup_with_animations(self):
126+
website = self.env.ref('website.default_website')
127+
website.cookies_bar = True
124128
self.start_tour(self.env['website'].get_client_action_url('/'), 'snippet_popup_and_animations', login='admin', timeout=90)
125129

126130
@unittest.skip

0 commit comments

Comments
 (0)