[FIX] hr_holidays: accrual plan day selection

Disable selecting non existing day of the month in accrual plan milestones
Task: 5998551

Author: renol-odoo

addons/hr_holidays/static/src/components/day_select/day_select.js

@@ -0,0 +1,48 @@
+import { registry } from "@web/core/registry";
+import { SelectionField, selectionField } from "@web/views/fields/selection/selection_field";
+import { useEffect, useState } from "@odoo/owl";
+
+function getDaysInMonth(month) {
+    const m = parseInt(month, 10);
+    if (!m || m < 1 || m > 12) return 31;
+    return new Date(2020, m, 0).getDate();
+}
+
+export class DaySelectField extends SelectionField {
+
+    static props = {
+        ...SelectionField.props,
+        monthField: { type: String, optional: true },
+    };
+
+    setup() {
+        super.setup();
+        this.ALL_DAY_OPTIONS = super.options;
+        this.ALL_DAY_OPTIONS.sort((a) => parseInt(a));
+        this.state = useState({
+            maxDays: getDaysInMonth(this.props.record.data[this.props.monthField]),
+        });
+
+        useEffect(() => {
+            const monthValue = this.props.record.data[this.props.monthField];
+            this.state.maxDays = getDaysInMonth(monthValue);
+        }, () => [this.props.record.data[this.props.monthField]]);
+    }
+
+    get options() {
+        return this.ALL_DAY_OPTIONS.slice(0, this.state.maxDays);
+    }
+}
+
+export const daySelect = {
+    ...selectionField,
+    component: DaySelectField,
+    extractProps(fieldInfo, widget) {
+        return {
+            ...selectionField.extractProps(fieldInfo, widget),
+            monthField: fieldInfo.attrs.month_field,
+        };
+    },
+};
+
+registry.category("fields").add("day_select", daySelect);

addons/hr_holidays/views/hr_leave_accrual_views.xml

@@ -36,17 +36,17 @@
                                 </span>
                                 <span name="biyearly" invisible="frequency != 'biyearly'">
                                     on the
-                                    <field nolabel="1" name="first_month_day" class="o_field_accrual" placeholder="select a day" required="frequency == 'biyearly'"/>
+                                    <field nolabel="1" name="first_month_day" class="o_field_accrual" widget="day_select" month_field="first_month" placeholder="select a day" required="frequency == 'biyearly'"/>
                                     of
                                     <field name="first_month" class="o_field_accrual" placeholder="select a month" required="frequency == 'biyearly'"/>
                                     and the
-                                    <field nolabel="1" name="second_month_day" class="o_field_accrual" placeholder="select a day" required="frequency == 'biyearly'"/>
+                                    <field nolabel="1" name="second_month_day" class="o_field_accrual" widget="day_select" month_field="second_month" placeholder="select a day" required="frequency == 'biyearly'"/>
                                     of
                                     <field nolabel="1" name="second_month" class="o_field_accrual" placeholder="select a month" required="frequency == 'biyearly'"/>
                                 </span>
                                 <span name="yearly" invisible="frequency != 'yearly'">
                                     on the
-                                    <field nolabel="1" name="yearly_day" class="o_field_accrual" required="frequency == 'yearly'" placeholder="select a day"/>
+                                    <field nolabel="1" name="yearly_day" class="o_field_accrual" widget="day_select" month_field="yearly_month" required="frequency == 'yearly'" placeholder="select a day"/>
                                     of
                                     <field nolabel="1" name="yearly_month" class="o_field_accrual" required="frequency == 'yearly'" placeholder="select a month"/>
                                 </span>
@@ -192,7 +192,7 @@
                                                options="{'links': {'other': 'carryover_custom_date'}, 'observe': 'carryover'}"/>
                                         <span id="carryover_custom_date">
                                             : the
-                                            <field name="carryover_day" placeholder="select a day"
+                                            <field name="carryover_day" placeholder="select a day" widget="day_select" month_field="carryover_month"
                                                    required="carryover_date == 'other'"/>
                                             of
                                             <field name="carryover_month" placeholder="select a month"