diff --git a/addons/hr/models/hr_employee.py b/addons/hr/models/hr_employee.py
index dc20f57822e22f..b470d2d7f557ef 100644
--- a/addons/hr/models/hr_employee.py
+++ b/addons/hr/models/hr_employee.py
@@ -495,7 +495,8 @@ def _compute_legal_name(self):
@api.depends('current_version_id')
@api.depends_context('version_id')
def _compute_version_id(self):
- context_version = self.env['hr.version'].browse(self.env.context.get('version_id', False))
+ context_version_id = self.env.context.get('version_id', False)
+ context_version = self.env['hr.version'].browse(context_version_id).exists() if context_version_id else self.env['hr.version']
for employee in self:
if context_version.employee_id == self:
diff --git a/addons/hr/tests/test_hr_version.py b/addons/hr/tests/test_hr_version.py
index ab585bc77163f2..241f7632a7926c 100644
--- a/addons/hr/tests/test_hr_version.py
+++ b/addons/hr/tests/test_hr_version.py
@@ -676,3 +676,20 @@ def test_hr_version_fields_tracking(self):
fields_without_tracking,
f"The following hr.version fields should have tracking=True: {fields_without_tracking}",
)
+
+ def test_delete_hr_version(self):
+ employee = self.env['hr.employee'].create(
+ {
+ 'name': 'John Doe',
+ 'date_version': '2024-01-01',
+ }
+ )
+
+ version1 = employee.version_id
+ version2 = employee.create_version({
+ 'date_version': '2025-01-01',
+ })
+
+ version1.unlink()
+ with self.assertRaises(ValidationError):
+ version2.unlink()
diff --git a/addons/hr/views/hr_employee_views.xml b/addons/hr/views/hr_employee_views.xml
index 3a733cf199e426..08dd2b395ff163 100644
--- a/addons/hr/views/hr_employee_views.xml
+++ b/addons/hr/views/hr_employee_views.xml
@@ -370,7 +370,7 @@
to
-
+
diff --git a/addons/hr_holidays/models/hr_leave_type.py b/addons/hr_holidays/models/hr_leave_type.py
index 8cedee4bed9165..f93d621cc8a732 100644
--- a/addons/hr_holidays/models/hr_leave_type.py
+++ b/addons/hr_holidays/models/hr_leave_type.py
@@ -280,7 +280,7 @@ def _search_virtual_remaining_leaves(self, operator, value):
leave_types = self.env['hr.leave.type'].search([])
def is_valid(leave_type):
- return not leave_type.requires_allocation or op(leave_type.virtual_remaining_leaves)
+ return not leave_type.requires_allocation or op(leave_type.virtual_remaining_leaves, value)
return [('id', 'in', leave_types.filtered(is_valid).ids)]
@api.depends_context('employee_id', 'default_employee_id', 'leave_date_from', 'default_date_from')
diff --git a/addons/hr_holidays/tests/test_hr_leave_type.py b/addons/hr_holidays/tests/test_hr_leave_type.py
index b7732013987c5d..f2ae35af62bc7e 100644
--- a/addons/hr_holidays/tests/test_hr_leave_type.py
+++ b/addons/hr_holidays/tests/test_hr_leave_type.py
@@ -114,3 +114,59 @@ def test_users_tz_shift_back(self):
).search([('has_valid_allocation', '=', True)], limit=1)
self.assertFalse(leave_types, "Got valid leaves outside vaild period")
+
+ def test_search_virtual_remaining_leaves(self):
+ employee = self.env['hr.employee'].create({'name': 'Test Employee'})
+ leave_type_1 = self.env['hr.leave.type'].create({
+ 'name': 'Test Leave 1',
+ 'requires_allocation': True,
+ })
+ leave_type_2 = self.env['hr.leave.type'].create({
+ 'name': 'Test Leave 2',
+ 'requires_allocation': False,
+ })
+
+ self.env['hr.leave.allocation'].sudo().create({
+ 'state': 'confirm',
+ 'holiday_status_id': leave_type_1.id,
+ 'employee_id': employee.id,
+ 'number_of_days': 4,
+ 'date_from': '2025-01-01',
+ 'date_to': '2025-12-31',
+ }).action_approve()
+
+ result = (
+ self.env["hr.leave.type"]
+ .with_context(employee_id=employee.id)
+ .search([("virtual_remaining_leaves", ">", 0)])
+ )
+ self.assertIn(
+ leave_type_1, result, "Leave Type 1 should be in the result as it has remaining leaves",
+ )
+ self.assertIn(
+ leave_type_2, result, "Leave Type 2 should be in the result since it does not require allocation",
+ )
+
+ result = (
+ self.env["hr.leave.type"]
+ .with_context(employee_id=employee.id)
+ .search([("virtual_remaining_leaves", "=", 0)])
+ )
+ self.assertNotIn(
+ leave_type_1, result, "Leave Type 1 should not be in the result as it has remaining leaves != 0",
+ )
+ self.assertIn(
+ leave_type_2, result, "Leave Type 2 should be in the result since it does not require allocation",
+ )
+
+ result = (
+ self.env["hr.leave.type"]
+ .with_context(employee_id=employee.id)
+ .search([("virtual_remaining_leaves", ">", 4)])
+ )
+ self.assertNotIn(
+ leave_type_1, result, "Leave Type 1 should not be in the result",
+ )
+ self.assertIn(
+ leave_type_2, result, "Leave Type 2 should be in the result since it does not require allocation",
+ )
diff --git a/addons/hr_skills/report/hr_employee_certification_report_views.xml b/addons/hr_skills/report/hr_employee_certification_report_views.xml
index 079ef1f790fd91..ee4394a120b6b7 100644
--- a/addons/hr_skills/report/hr_employee_certification_report_views.xml
+++ b/addons/hr_skills/report/hr_employee_certification_report_views.xml
@@ -45,27 +45,4 @@
-
- Certification
- hr.employee.certification.report
-
- list,pivot
- {
- 'search_default_employee': 1,
- }
-
-
-
- This report will give you an overview of the certification per Employee.
- Create them in configuration and add them on the Employee.
-
-
-
-
-
diff --git a/addons/hr_skills/report/hr_employee_skill_report_views.xml b/addons/hr_skills/report/hr_employee_skill_report_views.xml
index bddca497eb6efa..86b997da5ffbbe 100644
--- a/addons/hr_skills/report/hr_employee_skill_report_views.xml
+++ b/addons/hr_skills/report/hr_employee_skill_report_views.xml
@@ -89,6 +89,6 @@
id="hr_employee_skill_inventory_report_menu"
name="Skills Inventory"
action="hr_employee_skill_report_action"
- parent="hr_skills.hr_employee_skill_report_menu"
+ parent="hr.hr_menu_hr_reports"
sequence="15"/>
diff --git a/addons/hr_skills/views/hr_views.xml b/addons/hr_skills/views/hr_views.xml
index d90f958e3c8583..3e6e8d47e4ca92 100644
--- a/addons/hr_skills/views/hr_views.xml
+++ b/addons/hr_skills/views/hr_views.xml
@@ -593,7 +593,7 @@
hr.employee.skill
certifications
[('is_certification', '=', True)]
-
{'show_employee': True, 'search_default_group_by_type': 1}
+
{'show_employee': True}
list,form
-
-