[WIP]

Author: matho-odoo

src/actions/insert_actions.ts

@@ -275,6 +275,7 @@ export const categoriesFunctionListMenuBuilder: ActionBuilder = () => {
 
 export const insertLink: ActionSpec = {
   name: _t("Link"),
+  description: "Ctrl+K",
   execute: ACTIONS.INSERT_LINK,
   icon: "o-spreadsheet-Icon.INSERT_LINK",
 };
@@ -336,6 +337,7 @@ export const insertDropdown: ActionSpec = {
 
 export const insertSheet: ActionSpec = {
   name: _t("Insert sheet"),
+  description: "Shift+F11",
   execute: (env) => {
     const activeSheetId = env.model.getters.getActiveSheetId();
     const position = env.model.getters.getSheetIds().indexOf(activeSheetId) + 1;

src/components/filters/filter_menu/filter_menu.xml

@@ -42,7 +42,7 @@
         </SidePanelCollapsible>
 
         <div class="o-filter-menu-buttons d-flex justify-content-end">
-          <button class="o-button o-filter-menu-cancel me-2" t-on-click="cancel">Cancel</button>
+          <button class="o-button o-filter-menu-cancel me-2" t-on-click="cancel">Discard</button>
           <button class="o-button primary o-filter-menu-confirm" t-on-click="confirm">
             Confirm
           </button>

src/components/grid/grid.ts

@@ -17,6 +17,7 @@ import {
   useRef,
   useState,
 } from "@odoo/owl";
+import { insertSheet } from "../../actions/insert_actions";
 import {
   CREATE_IMAGE,
   INSERT_COLUMNS_BEFORE_ACTION,
@@ -409,6 +410,9 @@ export class Grid extends Component<Props, SpreadsheetChildEnv> {
     "Shift+PageUp": () => {
       this.env.model.dispatch("ACTIVATE_PREVIOUS_SHEET");
     },
+    "Shift+F11": () => {
+      insertSheet.execute?.(this.env);
+    },
     PageDown: () => this.env.model.dispatch("SHIFT_VIEWPORT_DOWN"),
     PageUp: () => this.env.model.dispatch("SHIFT_VIEWPORT_UP"),
     "Ctrl+K": () => INSERT_LINK(this.env),

src/components/link/link_editor/link_editor.xml

@@ -57,7 +57,7 @@
         onClose="() => this.menu.isOpen=false"
       />
       <div class="o-buttons">
-        <button t-on-click="cancel" class="o-button o-cancel me-2">Cancel</button>
+        <button t-on-click="cancel" class="o-button o-cancel me-2">Discard</button>
         <button t-on-click="save" class="o-button primary o-save" t-att-disabled="!link.url">
           Confirm
         </button>

src/components/side_panel/conditional_formatting/cf_editor/cf_editor.xml

@@ -40,7 +40,7 @@
       </Section>
       <Section class="'pt-1'">
         <div class="o-sidePanelButtons">
-          <button t-on-click="onCancel" class="o-button o-cf-cancel">Cancel</button>
+          <button t-on-click="onCancel" class="o-button o-cf-cancel">Discard</button>
           <button
             t-on-click="onSave"
             class="o-button primary o-cf-save"

src/components/side_panel/data_validation/dv_editor/dv_editor.xml

@@ -37,7 +37,7 @@
 
       <Section>
         <div class="o-sidePanelButtons">
-          <button t-on-click="props.onExit" class="o-dv-cancel o-button">Cancel</button>
+          <button t-on-click="props.onExit" class="o-dv-cancel o-button">Discard</button>
           <button t-on-click="onSave" class="o-dv-save o-button primary">Save</button>
         </div>
       </Section>

src/components/side_panel/pivot/pivot_measure_display_panel/pivot_measure_display_panel.xml

@@ -50,7 +50,7 @@
 
     <Section>
       <div class="o-sidePanelButtons">
-        <button t-on-click="onCancel" class="o-pivot-measure-cancel o-button">Cancel</button>
+        <button t-on-click="onCancel" class="o-pivot-measure-cancel o-button">Discard</button>
         <button t-on-click="onSave" class="o-pivot-measure-save o-button primary">Save</button>
       </div>
     </Section>

src/components/side_panel/table_style_editor_panel/table_style_editor_panel.xml

@@ -32,7 +32,7 @@
             class="o-delete o-button-danger o-button">
             Delete
           </button>
-          <button t-on-click="onCancel" class="o-cancel o-button">Cancel</button>
+          <button t-on-click="onCancel" class="o-cancel o-button">Discard</button>
           <button t-on-click="onConfirm" class="o-confirm o-button primary">Confirm</button>
         </div>
       </Section>

tests/grid/grid_component.test.ts

@@ -942,6 +942,9 @@ describe("Grid component", () => {
       expect(model.getters.getActiveSheetId()).toBe("third");
     });
 
+    // test("Pressing Shift+F11 insert a new sheet", () => {
+    //  });
+
     test("pressing Ctrl+K opens the link editor", async () => {
       await keyDown({ key: "k", ctrlKey: true });
       expect(fixture.querySelector(".o-link-editor")).not.toBeNull();