[IMP] rm cargo warnings

Author: fda-odoo

server/benches/iai_profiler.rs

@@ -1,13 +1,12 @@
 use lsp_server::Notification;
 use serde_json::json;
-use odoo_ls_server::{args::{Cli, LogLevel}, cli_backend::CliBackend, constants::*, server::Server, utils::PathSanitizer};
-use clap::Parser;
+use odoo_ls_server::{args::LogLevel, constants::*, server::Server, utils::PathSanitizer};
 use tracing::{info, Level};
 use tracing_appender::rolling::{RollingFileAppender, Rotation};
 use tracing_panic::panic_hook;
 use tracing_subscriber::{fmt, FmtSubscriber, layer::SubscriberExt};
 
-use std::{env, path::PathBuf};
+use std::env;
 
 use iai_callgrind::{
     library_benchmark, library_benchmark_group, main, LibraryBenchmarkConfig,
@@ -38,7 +37,7 @@ fn iai_main() {
     let mut exe_dir = env::current_exe().expect("Unable to get binary directory... aborting");
     exe_dir.pop();
 
-    let mut log_dir = exe_dir.join("logs").sanitize();
+    let log_dir = exe_dir.join("logs").sanitize();
 
     let file_appender = RollingFileAppender::builder()
         .max_log_files(5) // only the most recent 5 log files will be kept

server/src/constants.rs

@@ -1,7 +1,6 @@
 #![allow(non_camel_case_types)]
 use core::fmt;
 
-use byteyarn::{yarn, Yarn};
 
 pub const EXTENSION_NAME: &str = "Odoo";
 pub const EXTENSION_VERSION: &str = "0.12.0";
@@ -35,6 +34,8 @@ macro_rules! oyarn {
 #[cfg(all(feature="debug_yarn", debug_assertions))]
 pub type OYarn = String;
 #[cfg(not(all(feature="debug_yarn", debug_assertions)))]
+use byteyarn::Yarn;
+#[cfg(not(all(feature="debug_yarn", debug_assertions)))]
 pub type OYarn = Yarn;
 
 pub fn tree(a: Vec<&str>, b: Vec<&str>) -> Tree {

server/src/core/csv_arch_builder.rs

@@ -1,10 +1,10 @@
-use std::{cell::RefCell, fs::File, path::PathBuf, rc::{Rc, Weak}};
+use std::{cell::RefCell, path::PathBuf, rc::{Rc, Weak}};
 
-use csv::{StringRecord, StringRecordIter};
-use lsp_types::{Diagnostic, Position, Range};
+use csv::StringRecord;
+use lsp_types::Diagnostic;
 use weak_table::PtrWeakHashSet;
 
-use crate::{constants::{BuildStatus, BuildSteps, OYarn}, core::{file_mgr::FileInfo, xml_data::{OdooData, OdooDataField, OdooDataRecord}}, oyarn, threads::SessionInfo, Sy, S};
+use crate::{constants::{BuildStatus, BuildSteps, OYarn}, core::xml_data::{OdooData, OdooDataField, OdooDataRecord}, oyarn, threads::SessionInfo, Sy};
 
 use super::{symbols::{symbol::Symbol}};
 
@@ -19,7 +19,7 @@ impl CsvArchBuilder {
     }
 
     pub fn load_csv(&mut self, session: &mut SessionInfo, csv_symbol: Rc<RefCell<Symbol>>, content: &String) -> Vec<Diagnostic> {
-        let mut diagnostics = vec![];
+        let diagnostics = vec![];
         csv_symbol.borrow_mut().set_build_status(BuildSteps::ARCH, BuildStatus::IN_PROGRESS);
         let model_name_pb = PathBuf::from(&csv_symbol.borrow().paths()[0]);
         let model_name = Sy!(model_name_pb.file_stem().unwrap().to_str().unwrap().to_string());
@@ -32,7 +32,7 @@ impl CsvArchBuilder {
             let csv = csv_sym.as_csv_file_sym_mut();
             let mut rdr = csv::Reader::from_reader(content.as_bytes());
             if rdr.has_headers() {
-                for header in rdr.headers() {
+                if let Ok(header) = rdr.headers() {
                     for h in header.iter() {
                         csv.headers.push(oyarn!("{}", h));
                     }
@@ -42,14 +42,13 @@ impl CsvArchBuilder {
                 for result in rdr.records() {
                     if let Ok(result) = result {
                         let record = self.extract_record(Rc::downgrade(&csv_symbol), model_name.clone(), &csv.headers, &result);
-                        if let Some(mut record) = record {
+                        if let Some(record) = record {
                             if let Some(xml_id) = record.xml_id.as_ref() {
                                 let id_split = xml_id.split(".").collect::<Vec<&str>>();
                                 if id_split.len() > 2 {
                                     //TODO diagnostic
                                     continue;
                                 }
-                                let id = id_split.last().unwrap().to_string();
                                 let mut csv_module = csv_module.clone();
                                 if id_split.len() == 2 {
                                     let module_name = Sy!(id_split.first().unwrap().to_string());

server/src/core/entry_point.rs

@@ -1,6 +1,5 @@
-use std::{cell::RefCell, cmp, collections::HashMap, path::{self, PathBuf}, rc::{Rc, Weak}, u32};
+use std::{cell::RefCell, cmp, collections::HashMap, path::PathBuf, rc::{Rc, Weak}, u32};
 
-use byteyarn::Yarn;
 use tracing::{error, info, warn};
 use weak_table::PtrWeakHashSet;
 

server/src/core/evaluation.rs

@@ -328,7 +328,7 @@ impl Evaluation {
         }
     }
 
-    pub fn new_domain(odoo: &mut SyncOdoo) -> Evaluation {
+    pub fn new_domain(_odoo: &mut SyncOdoo) -> Evaluation {
         Evaluation {
             symbol: EvaluationSymbol {
                 sym: EvaluationSymbolPtr::DOMAIN,
@@ -438,7 +438,7 @@ impl Evaluation {
             EvaluationSymbolPtr::WEAK(_) => {
                 //take the weak by get_symbol instead of the match
                 let symbol_eval = self.symbol.get_symbol(session, &mut None, &mut vec![], Some(function.clone()));
-                let out_of_scope = Symbol::follow_ref(&symbol_eval, session, &mut None, false, false, Some(function.clone()), &mut vec![]);
+                let out_of_scope = Symbol::follow_ref(&symbol_eval, session, &mut None, false, false, Some(function.clone()));
                 for sym in out_of_scope {
                     if !sym.is_expired_if_weak() {
                         res.push(Evaluation {
@@ -467,7 +467,7 @@ impl Evaluation {
             if eval_symbol.is_expired_if_weak() {
                 return None;
             }
-            let evals = Symbol::follow_ref(&eval_symbol, session, context, false, true, None, diagnostics);
+            let evals = Symbol::follow_ref(&eval_symbol, session, context, false, true, None);
             if evals.len() == 1 {
                 let eval = &evals[0];
                 match eval {
@@ -771,7 +771,7 @@ impl Evaluation {
                 }
                 let base_eval_ptrs: Vec<EvaluationSymbolPtr> = base_evals.iter().map(|base_eval| {
                     let base_sym_weak_eval_base = base_eval.symbol.get_symbol_weak_transformed(session, context, &mut diagnostics, None);
-                    Symbol::follow_ref(&base_sym_weak_eval_base, session, context, true, false, None, &mut diagnostics)
+                    Symbol::follow_ref(&base_sym_weak_eval_base, session, context, true, false, None)
                 }).flatten().collect();
 
                 let parent_file_or_func = parent.clone().borrow().parent_file_or_function().as_ref().unwrap().upgrade().unwrap();
@@ -802,7 +802,7 @@ impl Evaluation {
                                     let res = class_sym_weak_eval.weak.upgrade().and_then(|class_sym|{
                                         let class_sym_weak_eval = &Symbol::follow_ref(&&EvaluationSymbolPtr::WEAK(EvaluationSymbolWeak::new(
                                             Rc::downgrade(&class_sym), None, false
-                                        )), session, &mut None, false, false, None, &mut diagnostics)[0];
+                                        )), session, &mut None, false, false, None)[0];
                                         if class_sym_weak_eval.upgrade_weak().unwrap().borrow().typ() != SymType::CLASS{
                                             return None;
                                         }
@@ -831,7 +831,7 @@ impl Evaluation {
                                                 let object_or_type_weak_eval = &Symbol::follow_ref(
                                                     &object_or_type_eval[0].symbol.get_symbol(
                                                         session, context, &mut diagnostics, Some(parent.clone())),
-                                                        session, &mut None, false, false, None, &mut diagnostics)[0];
+                                                        session, &mut None, false, false, None)[0];
                                                 if object_or_type_weak_eval.is_weak() {
                                                     is_instance = Some(object_or_type_weak_eval.as_weak().instance.unwrap_or(default_instance));
                                                 } else {
@@ -1022,7 +1022,7 @@ impl Evaluation {
                     if base_ref.is_expired_if_weak() {
                         return AnalyzeAstResult::from_only_diagnostics(diagnostics);
                     }
-                    let bases = Symbol::follow_ref(&base_ref, session, context, false, false, None, &mut diagnostics);
+                    let bases = Symbol::follow_ref(&base_ref, session, context, false, false, None);
                     for ibase in bases.iter() {
                         let base_loc = ibase.upgrade_weak();
                         if let Some(base_loc) = base_loc {
@@ -1144,7 +1144,7 @@ impl Evaluation {
                 if base.is_expired_if_weak() {
                     return AnalyzeAstResult::from_only_diagnostics(diagnostics);
                 }
-                let bases = Symbol::follow_ref(&base, session, &mut None, false, false, None, &mut diagnostics);
+                let bases = Symbol::follow_ref(&base, session, &mut None, false, false, None);
                 if bases.len() != 1 {
                     return AnalyzeAstResult::from_only_diagnostics(diagnostics);
                 }
@@ -1261,7 +1261,7 @@ impl Evaluation {
                 diagnostics.extend(diags);
                 for base in bases.into_iter(){
                     let base_sym_weak_eval= base.symbol.get_symbol_weak_transformed(session, context, &mut diagnostics, None);
-                    let base_eval_ptrs = Symbol::follow_ref(&base_sym_weak_eval, session, context, true, false, None, &mut diagnostics);
+                    let base_eval_ptrs = Symbol::follow_ref(&base_sym_weak_eval, session, context, true, false, None);
                     for base_eval_ptr in base_eval_ptrs.iter() {
                         let EvaluationSymbolPtr::WEAK(base_sym_weak_eval) = base_eval_ptr else {continue};
                         let Some(base_sym) = base_sym_weak_eval.weak.upgrade() else {continue};
@@ -1531,7 +1531,7 @@ impl Evaluation {
         diagnostics
     }
 
-    fn validate_tuple_search_domain(session: &mut SessionInfo, on_object: Weak<RefCell<Symbol>>, from_module: Option<Rc<RefCell<Symbol>>>, elt1: &Expr, elt2: &Expr, elt3: &Expr, diagnostics: &mut Vec<Diagnostic>) {
+    fn validate_tuple_search_domain(session: &mut SessionInfo, on_object: Weak<RefCell<Symbol>>, from_module: Option<Rc<RefCell<Symbol>>>, elt1: &Expr, elt2: &Expr, _elt3: &Expr, diagnostics: &mut Vec<Diagnostic>) {
         //parameter 1
         if let Some(on_object) = on_object.upgrade() { //if weak is not set, we didn't manage to evalue base object. Do not validate in this case
             match elt1 {
@@ -1763,7 +1763,7 @@ impl EvaluationSymbolPtr {
 
     pub(crate) fn is_weak(&self) -> bool {
         match self {
-            EvaluationSymbolPtr::WEAK(w) => true,
+            EvaluationSymbolPtr::WEAK(_) => true,
             _ => false
         }
     }

server/src/core/file_mgr.rs

@@ -1,7 +1,7 @@
 use lsp_types::notification::{Notification, PublishDiagnostics};
 use ropey::Rope;
-use ruff_python_ast::{AnyRootNodeRef, Mod, ModModule, PySourceType, Stmt};
-use ruff_python_parser::{Mode, ParseOptions, Parsed, Token, TokenKind};
+use ruff_python_ast::{ModModule, PySourceType, Stmt};
+use ruff_python_parser::{Parsed, Token, TokenKind};
 use lsp_types::{Diagnostic, DiagnosticSeverity, MessageType, NumberOrString, Position, PublishDiagnosticsParams, Range, TextDocumentContentChangeEvent};
 use tracing::{error, warn};
 use std::collections::hash_map::DefaultHasher;

server/src/core/model.rs

@@ -12,7 +12,6 @@ use crate::constants::BuildSteps;
 use crate::constants::OYarn;
 use crate::constants::SymType;
 use crate::threads::SessionInfo;
-use crate::Sy;
 
 use super::symbols::module_symbol::ModuleSymbol;
 use super::symbols::symbol::Symbol;

server/src/core/odoo.rs

@@ -1,7 +1,6 @@
 use crate::core::diagnostics::{create_diagnostic, DiagnosticCode};
 use crate::core::entry_point::EntryPointType;
 use crate::core::file_mgr::AstType;
-use crate::core::symbols::file_symbol;
 use crate::core::xml_data::OdooData;
 use crate::core::xml_validation::XmlValidator;
 use crate::features::document_symbols::DocumentSymbolFeature;
@@ -20,7 +19,6 @@ use std::time::Instant;
 use lsp_server::ResponseError;
 use lsp_types::*;
 use request::{RegisterCapability, Request, WorkspaceConfiguration};
-use ruff_python_parser::{Mode, ParseOptions};
 use serde_json::Value;
 use tracing::{error, warn, info, trace};
 
@@ -1321,7 +1319,7 @@ impl Odoo {
         Ok(None)
     }
 
-    pub fn handle_did_change_configuration(session: &mut SessionInfo, _params: DidChangeConfigurationParams) {
+    pub fn handle_did_change_configuration(_session: &mut SessionInfo, _params: DidChangeConfigurationParams) {
         return;
     }
 
@@ -1593,7 +1591,7 @@ impl Odoo {
         (false, false)
     }
 
-    pub fn update_file_index(session: &mut SessionInfo, path: PathBuf, is_save: bool, is_open: bool, force_delay: bool) {
+    pub fn update_file_index(session: &mut SessionInfo, path: PathBuf, is_save: bool, _is_open: bool, force_delay: bool) {
         if matches!(path.extension().and_then(OsStr::to_str), Some(ext) if ["py", "xml", "csv"].contains(&ext)) || Odoo::is_config_workspace_file(session, &path){
             SessionInfo::request_update_file_index(session, &path, is_save, force_delay);
         }