[FIX] server: add context to event queue.

Language server was not added to the context of the event queue and so was sometimes crashing when a file is edited.

Author: fda-odoo

server/odoo_language_server.py

@@ -9,6 +9,12 @@
 from .update_event_queue import UpdateEventQueue
 
 
+def _prepare_ctxt_thread(odoo_server, target, args):
+    OdooLanguageServer.instance.set(odoo_server)
+    OdooLanguageServer.access_mode.set("none")
+    target(*args)
+
+
 class OdooLanguageServer(LanguageServer):
 
     instance = contextvars.ContextVar('instance', default=None)
@@ -26,11 +32,14 @@ def report_server_error(self, error: Exception, source):
         odoo_server.send_notification("Odoo/displayCrashNotification", {"crashInfo": traceback.format_exc()})
 
     def launch_thread(self, target, args):
-        def prepare_ctxt_thread(odoo_server, target, args):
-            OdooLanguageServer.instance.set(odoo_server)
-            OdooLanguageServer.access_mode.set("none")
-            target(*args)
-        threading.Thread(target=prepare_ctxt_thread, args=(self, target, args)).start()
+        thread = threading.Thread(target=_prepare_ctxt_thread, args=(self, target, args))
+        thread.start()
+        return thread
+
+    def launch_thread_timer(self, target, args, delay):
+        thread = threading.Timer(delay, function=_prepare_ctxt_thread, args=(self, target, args))
+        thread.start()
+        return thread
 
     @staticmethod
     def get():

server/update_event_queue.py

@@ -59,20 +59,20 @@ def set_delay(self, delay):
         self.delay = delay / 1000.0
 
     def push(self, event:UpdateEvent):
+        from .odoo_language_server import OdooLanguageServer
         with self.lock:
             if self.panic_mode:
                 #do no add anything, but update time of the last event
                 if self.queue:
                     self.queue[-1].time = time.time()
                 return
-            self.queue = [e for e in self.queue if e.path != event.path]
+            self.queue = [e for e in self.queue if e.path != event.path] #TODO write this with a set
             if len(self.queue) > 10:
                 self.panic_mode = True
             event.time = time.time()
             self.queue.append(event)
             if self.thread is None:
-                self.thread = threading.Timer(self.delay, self.process)
-                self.thread.start()
+                self.thread = OdooLanguageServer.get().launch_thread_timer(target=self.process, args=(), delay = self.delay)
 
     def clear(self):
         with self.lock:
@@ -85,8 +85,7 @@ def process(self):
             self.thread = None
             if self.queue:
                 if self.queue[-1].time + self.delay > time.time():
-                    self.thread = threading.Timer(self.queue[-1].time + self.delay - time.time(), self.process)
-                    self.thread.start()
+                    self.thread = odoo_server.launch_thread_timer(target=self.process, args=(), delay = self.queue[-1].time + self.delay - time.time())
                     return
                 if self.panic_mode:
                     Odoo.reload_database(odoo_server)
@@ -100,5 +99,4 @@ def process(self):
                 if acquired:
                     Odoo.get().process_rebuilds(odoo_server)
                 else:
-                    self.thread = threading.Timer(1.0, self.process)
-                    self.thread.start()
+                    self.thread = odoo_server.launch_thread_timer(target=self.process, args=(self,), delay = 1.0)