[FIX] estate: chapter 9 (actions)

Author: tskv

estate/__manifest__.py

@@ -9,7 +9,6 @@
     """,
     'data': [
         'security/ir.model.access.csv',
-
         'views/estate_property_views.xml',
         'views/estate_property_type_views.xml',
         'views/estate_property_tag_views.xml',

estate/models/estate_property.py

@@ -1,7 +1,6 @@
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
 from odoo import fields, models, api, exceptions
-from datetime import timedelta
 
 
 class EstateProperty(models.Model):
@@ -12,7 +11,7 @@ class EstateProperty(models.Model):
     active = fields.Boolean('Active', default=True)
     description = fields.Text('Description')
     postcode = fields.Char('Postcode')
-    date_availability = fields.Date('Available From', copy=False, default=fields.Datetime.now() + timedelta(days=90))
+    date_availability = fields.Date('Available From', copy=False, default=fields.Date.add(fields.Date.today(), months=3))
     expected_price = fields.Float('Expected Price', required=True)
     selling_price = fields.Float('Selling Price', readonly=True, copy=False)
     bedrooms = fields.Integer('Bedrooms', default=2)
@@ -44,6 +43,16 @@ class EstateProperty(models.Model):
     total_area = fields.Integer('Total Area (sqm)', compute='_compute_total_area')
     best_offer = fields.Float('Best Offer', compute='_compute_best_offer')
 
+    _check_expected_price = models.Constraint(
+        'CHECK(expected_price > 0)',
+        'The expected price must be strictly positive',
+    )
+
+    _check_selling_price = models.Constraint(
+        'CHECK(selling_price >= 0)',
+        'The selling price must be positive',
+    )
+
     @api.depends('garden_area', 'living_area')
     def _compute_total_area(self):
         for record in self:
@@ -68,16 +77,16 @@ def _onchange_garden(self):
 
     def property_sold(self):
         for record in self:
-            if self.state != 'cancelled':
-                self.state = 'sold'
+            if record.state != 'cancelled':
+                record.state = 'sold'
             else:
                 raise exceptions.UserError("Sold properties cannot be cancelled.")
         return True
 
     def property_cancelled(self):
         for record in self:
-            if self.state != 'sold':
-                self.state = 'cancelled'
+            if record.state != 'sold':
+                record.state = 'cancelled'
             else:
                 raise exceptions.UserError("Cancelled properties cannot be sold.")
         return True

estate/models/estate_property_offer.py

@@ -16,6 +16,11 @@ class EstatePropertyOffer(models.Model):
     validity = fields.Integer(string='Validity (days)', default=7)
     date_deadline = fields.Date(string='Deadline', compute='_compute_deadline', inverse='_inverse_deadline')
 
+    _check_price = models.Constraint(
+        'CHECK(price > 0)',
+        'The offer price must be strictly positive',
+    )
+
     @api.depends('validity')
     def _compute_deadline(self):
         for record in self:

estate/models/estate_property_tag.py

@@ -8,3 +8,8 @@ class EstatePropertyTag(models.Model):
     _description = 'Estate Property Tag'
 
     name = fields.Char(string='Property Tag', required=True)
+
+    _tag_name_uniq = models.Constraint(
+        'unique(name)',
+        "The property tag name must be unique",
+    )

estate/models/estate_property_type.py

@@ -8,3 +8,8 @@ class EstatePropertyType(models.Model):
     _description = 'Estate Property Type'
 
     name = fields.Char(string='Property Type', required=True)
+
+    _type_name_uniq = models.Constraint(
+        'unique(name)',
+        "The property type name must be unique",
+    )

estate/views/estate_menus.xml

@@ -7,7 +7,7 @@
         id="properties_menu"
         name="Properties"
         parent="estate_menu_root"
-        action="estate.estate_property_action"
+        action="estate_property_action"
         sequence="1"/>
     <menuitem
         id="settings_menu"
@@ -18,12 +18,12 @@
         id="properties_type_menu"
         name="Property Types"
         parent="settings_menu"
-        action="estate.estate_property_type_action"
+        action="estate_property_type_action"
         sequence="1"/>
     <menuitem
         id="properties_tag_menu"
         name="Property Tags"
         parent="settings_menu"
-        action="estate.estate_property_tag_action"
+        action="estate_property_tag_action"
         sequence="2"/>
 </odoo>