From 568a1073598bbfb58dfe43448c3aee969c86ab88 Mon Sep 17 00:00:00 2001 From: Francesco Witte Date: Wed, 12 Feb 2025 16:54:49 +0100 Subject: [PATCH] Fix the electrolyzer example and remove an unused part in fluid vector presolving (for now) --- src/tespy/components/reactors/water_electrolyzer.py | 4 ++-- src/tespy/networks/network.py | 8 +++++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/tespy/components/reactors/water_electrolyzer.py b/src/tespy/components/reactors/water_electrolyzer.py index 76a83f0a9..d1299a00a 100644 --- a/src/tespy/components/reactors/water_electrolyzer.py +++ b/src/tespy/components/reactors/water_electrolyzer.py @@ -176,10 +176,10 @@ class WaterElectrolyzer(Component): >>> round(el.eta.val, 1) 0.8 >>> el_cmp.set_attr(v=None) - >>> el.set_attr(P=P_design * 0.66) + >>> el.set_attr(P=P_design * 1e6 * 0.2) >>> nw.solve('offdesign', design_path='tmp') >>> round(el.eta.val, 2) - 0.88 + 0.84 >>> shutil.rmtree('./tmp', ignore_errors=True) """ diff --git a/src/tespy/networks/network.py b/src/tespy/networks/network.py index 3f4580a3d..c57adc9d7 100644 --- a/src/tespy/networks/network.py +++ b/src/tespy/networks/network.py @@ -1109,9 +1109,11 @@ def presolve_fluid_topology(self): main_conn.fluid.val.update(fixed_fractions) main_conn.fluid.is_set = {f for f in fixed_fractions} main_conn.fluid.is_var = variable - num_var = len(variable) - for f in variable: - main_conn.fluid.val[f] = (1 - mass_fraction_sum) / num_var + # this seems to be a problem in some cases, e.g. the basic + # gas turbine tutorial + # num_var = len(variable) + # for f in variable: + # main_conn.fluid.val[f] = (1 - mass_fraction_sum) / num_var [c.build_fluid_data() for c in all_connections] for fluid in main_conn.fluid.is_var: