Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running the postprocessing if a solution is not fully converged can leave side-effects #608

Closed
fw-bh opened this issue Feb 10, 2025 · 0 comments · Fixed by #609
Closed

Comments

@fw-bh
Copy link

fw-bh commented Feb 10, 2025

Running the postprocessing on a not-converged solution leads to changes in connection, component or bus parameters in a way, that a result for a parameter may not be identical to the original input specification, i.e. isentropic efficiency was specified as 0.8 and ends up being 0.9. With this, a new solve call will impose the (wrong) result of that parameter to the model.

A reasonable solution would be to either

  • run the postprocessing only, if a solution is fully converged (this however is not healing the original reason)
  • or instead only update those component, connection and bus parameters, that are not inputs (i.e. where is_set is False). Those that are inputs should be stayed untouched.

The second option might work well together with the changes suggested in #591 as it can easily be automized and does not need to be changed for every single parameter individually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant