Remove unnecessary null pointer checks

[elfring]

Extra null pointer checks are not needed in functions like the following.

• bf_Close
• u8x8_bitmap_SetSize

[olikraus]

what exactly is the problem here?

[elfring]

I am still curious then if another software developer (besides me) can get into the mood to apply a corresponding update suggestion which could be generated by the software “Coccinelle” (also with the help of a variant from the following script).

@Remove_unnecessary_pointer_checks@
expression x;
@@
-if (\(x != 0 \| x != NULL\))
    free(x);

[olikraus]

ok, got the point...
https://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first

I wonder whether this is really worth to fix... What is your motivation to request a fix for this issue?

[elfring]

I suggest to achieve another small source code reduction.

[olikraus]

I suggest to achieve another small source code reduction.

but the related code is either for the external font converter (which will never go to any embedded system) or is very special and also not part of the embedded u8g2 distribution.

I mean there will be no effect on the code size. U8g2 itself does not use malloc/free.

[olikraus]

ok, bf_Close is not part of the embedded code and also u8x8_bitmap_SetSize is not part of the standard u8g2 lib. In fact u8x8_bitmap_SetSize functionality is replaced by writeBitmapXBM function, see #1005

I will but this on hold...