Skip to content

Commit edb7cdf

Browse files
committed
fixes
1 parent eb3487c commit edb7cdf

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

README.md

+13-13
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
3. Open the Apple Developer App and subscribe to the $99 Apple Developer Program, providing accurate details as per your *National ID*.
1515
4. Wait until you receive the Apple Developer Program Welcome Email, which may take up to 48 hours.
1616

17-
![Apple Developer Program Subscription](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/apple-developer-program.png)
17+
![Apple Developer Program Subscription](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/apple-developer-program.jpg)
1818

1919
**2. Get Required Credentials**
2020

@@ -23,7 +23,7 @@
2323
2. Sign in to your Apple Account.
2424
3. Create a new App Specific Password and store it securely.
2525

26-
![App Specific Password Creation](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/app-specific-password.png)
26+
![App Specific Password Creation](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/app-specific-password.jpg)
2727
*Creating an app-specific password in Apple Account settings*
2828

2929
*Developer ID Application Certificate:*
@@ -35,13 +35,13 @@
3535
- Name the file "certificate".
3636
- Save "certificate.p12" in a secure location.
3737

38-
![Export Certificate](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/export-certificate.png)
38+
![Export Certificate](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/export-certificate.jpg)
3939

4040
*Team ID:*
4141
1. Visit https://developer.apple.com/account.
4242
2. Scroll to the "Membership details" Card and copy the "Team ID" to a secure place.
4343

44-
![Apple Developer Team ID](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/team-id.png)
44+
![Apple Developer Team ID](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/team-id.jpg)
4545
*Finding your Team ID in the Apple Developer Portal*
4646

4747
**3. Sign and Notarize Sample Application**
@@ -75,7 +75,7 @@ npm run package
7575
5. Run `bash package-mac-signed.sh`.
7676
6. Once you see the "notarization successful" message in the terminal, you can now distribute the ".dmg" via the internet to your users without facing any security warnings. Hurray! 🎉
7777

78-
![Notarization Success](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/notarization-success.png)
78+
![Notarization Success](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/notarization-success.jpg)
7979
*Successful notarization message in terminal*
8080

8181
7. Now, let's proceed to sign and notarize your own custom application using Electron Builder.
@@ -249,13 +249,13 @@ certificate.p12
249249
9. Run `bash package-mac-signed.sh`.
250250
10. Wait until you see the "notarization successful" message in the terminal - your app is ready for the world to see! Congratulations! 🎉
251251

252-
![Notarization Success](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/notarization-success.png)
252+
![Notarization Success](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/notarization-success.jpg)
253253
*Your signed app is now ready for distribution*
254254

255255
### ❓ How to automate the above process using GitHub Actions?
256256
**1. GitHub Repository Setup**
257257
1. Create a new repository.
258-
![new-repo-code-signing](https://raw.githubusercontent.com/omkarcloud/botasaurus/master/images/new-repo-code-signing.png)
258+
![new-repo-code-signing](https://raw.githubusercontent.com/omkarcloud/botasaurus/master/images/new-repo-code-signing.jpg)
259259
2. Push your code.
260260
3. Encode the certificate and save the output in a secure place:
261261
```bash
@@ -264,9 +264,9 @@ base64 -i certificate.p12
264264

265265
**2. Create an S3 Bucket**
266266
1. Open the AWS Console > S3.
267-
![aws-s3](https://raw.githubusercontent.com/omkarcloud/botasaurus/master/images/aws-s3.png)
267+
![aws-s3](https://raw.githubusercontent.com/omkarcloud/botasaurus/master/images/aws-s3.jpg)
268268
2. Click "Create bucket".
269-
![create-bucket](https://raw.githubusercontent.com/omkarcloud/botasaurus/master/images/create-bucket.png)
269+
![create-bucket](https://raw.githubusercontent.com/omkarcloud/botasaurus/master/images/create-bucket.jpg)
270270
3. Configure the bucket:
271271
```
272272
Bucket name: Enter a unique bucket name. Conventionally, this name matches your product's name in kebab case. For example, if your product's name is "Chess Master," your bucket name will be `chess-master`.
@@ -281,7 +281,7 @@ Ensure that **Object Ownership** is set to **"ACLs enabled"** because Electron B
281281
![ACL Error](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/acl-error.png)
282282

283283
4. Click on "Create bucket".
284-
![S3 Bucket Creation](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/s3-bucket-setup.png)
284+
![S3 Bucket Creation](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/s3-bucket-setup.jpg)
285285

286286
5. If you don't have an AWS access key and secret key, create them through the IAM service as described in [AWS documentation here](https://docs.aws.amazon.com/IAM/latest/UserGuide/id_root-user_manage_add-key.html).
287287

@@ -297,7 +297,7 @@ AWS_ACCESS_KEY_ID # AWS access key
297297
AWS_SECRET_ACCESS_KEY # AWS secret key
298298
```
299299

300-
![GitHub Secrets](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/github-secrets.png)
300+
![GitHub Secrets](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/github-secrets.jpg)
301301

302302
**4. Configure Electron Builder**
303303
1. In your "package.json" file, add the following to the Electron "build" configuration:
@@ -416,7 +416,7 @@ jobs:
416416
**6. Deploy**
417417
1. Push the code to your GitHub repository.
418418
2. Go to the repository's "Actions" tab to see the build process in action.
419-
![GitHub Actions Workflow](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/github-actions.png)
419+
![GitHub Actions Workflow](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/github-actions.jpg)
420420
3. After a successful build, the installer files will be found in your S3 bucket. These files will be publicly accessible in the following format:
421421
```
422422
https://<your-bucket-name>.s3.amazonaws.com/<your-product-name>.dmg
@@ -430,7 +430,7 @@ Examples:
430430

431431
4. Share the URL with your users to download the signed and notarized executable. Hurray! 🎉
432432

433-
![S3 Distribution](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/s3-distribution.png)
433+
![S3 Distribution](https://raw.githubusercontent.com/omkarcloud/macos-code-signing-example/master/images/s3-distribution.jpg)
434434

435435
### ❓ How to Set Up Auto Update for my Electron App?
436436

0 commit comments

Comments
 (0)