-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Instructions
FlowYieldVaultsEVM was added as a submodule recently. We skipped writing new integration tests as the current FlowYieldVaultsEVM repository provides a basic integration test.
Issue To Be Solved
We still think a test suite is needed in theFlowYieldVaults repo to confirm correct functionality of submodule.
Solution
Multiple ways to solve this issue:
- Write a new integration test suite in
FlowYieldVaults(there's a draft here) - Update the integration test in
FlowYieldVaultsEVMto be re-usable. Call it fromFlowYieldVaults. - Copy the code from
FlowYieldVaultsEVMintoFlowYieldVaultsinstead of using submodules. The original integration test will then serve as the only correct one. This can also solve the current potential submodule import loop (FlowYieldVaultshasFlowYieldVaultsEVMandFlowYieldVaultsEVMhasFlowYieldVaultsas submodules)
Metadata
Metadata
Assignees
Labels
No labels