Skip to content

[IMPROVEMENT] Add integration test for FlowYieldVaultsEVM #111

@nvdtf

Description

@nvdtf

Instructions

FlowYieldVaultsEVM was added as a submodule recently. We skipped writing new integration tests as the current FlowYieldVaultsEVM repository provides a basic integration test.

Issue To Be Solved

We still think a test suite is needed in theFlowYieldVaults repo to confirm correct functionality of submodule.

Solution

Multiple ways to solve this issue:

  • Write a new integration test suite in FlowYieldVaults (there's a draft here)
  • Update the integration test in FlowYieldVaultsEVM to be re-usable. Call it from FlowYieldVaults.
  • Copy the code from FlowYieldVaultsEVM into FlowYieldVaults instead of using submodules. The original integration test will then serve as the only correct one. This can also solve the current potential submodule import loop (FlowYieldVaults has FlowYieldVaultsEVM and FlowYieldVaultsEVM has FlowYieldVaults as submodules)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions