Skip to content

Commit a9162b6

Browse files
committed
update addon manager.
Signed-off-by: morvencao <[email protected]>
1 parent a78571c commit a9162b6

File tree

10 files changed

+280
-225
lines changed

10 files changed

+280
-225
lines changed

go.mod

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ require (
3434
k8s.io/klog/v2 v2.120.1
3535
k8s.io/kube-aggregator v0.29.3
3636
k8s.io/utils v0.0.0-20240310230437-4693a0247e57
37-
open-cluster-management.io/addon-framework v0.9.1-0.20240416063208-ecb7f349df05
37+
open-cluster-management.io/addon-framework v0.9.1-0.20240419070222-e703fc5a2556
3838
open-cluster-management.io/api v0.13.1-0.20240411131856-8f6aa25f111c
39-
open-cluster-management.io/sdk-go v0.13.1-0.20240416030555-aa744f426379
39+
open-cluster-management.io/sdk-go v0.13.1-0.20240416062924-20307e6fe090
4040
sigs.k8s.io/controller-runtime v0.17.3
4141
sigs.k8s.io/kube-storage-version-migrator v0.0.6-0.20230721195810-5c8923c5ff96
4242
)

go.sum

+4-4
Original file line numberDiff line numberDiff line change
@@ -423,12 +423,12 @@ k8s.io/kube-openapi v0.0.0-20231010175941-2dd684a91f00 h1:aVUu9fTY98ivBPKR9Y5w/A
423423
k8s.io/kube-openapi v0.0.0-20231010175941-2dd684a91f00/go.mod h1:AsvuZPBlUDVuCdzJ87iajxtXuR9oktsTctW/R9wwouA=
424424
k8s.io/utils v0.0.0-20240310230437-4693a0247e57 h1:gbqbevonBh57eILzModw6mrkbwM0gQBEuevE/AaBsHY=
425425
k8s.io/utils v0.0.0-20240310230437-4693a0247e57/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
426-
open-cluster-management.io/addon-framework v0.9.1-0.20240416063208-ecb7f349df05 h1:oj4IEyxmQFMxdpnOPE/Y7Xkyfkz4hGVkcYZ4dn8WtKU=
427-
open-cluster-management.io/addon-framework v0.9.1-0.20240416063208-ecb7f349df05/go.mod h1:K+/TwCUz2PZ7L+svaodw6029S/iPJ7eVX21F7NMw+Kw=
426+
open-cluster-management.io/addon-framework v0.9.1-0.20240419070222-e703fc5a2556 h1:X3vJEx9agC94l7SitpWZFDshISdL1niqVH0+diyqfJo=
427+
open-cluster-management.io/addon-framework v0.9.1-0.20240419070222-e703fc5a2556/go.mod h1:HayKCznnlyW+0dUJQGj5sNR6i3tvylSySD3YnvZkBtY=
428428
open-cluster-management.io/api v0.13.1-0.20240411131856-8f6aa25f111c h1:/iUoY6/PqBmcBq3v0+UBFvIcI39k/QPRGqpOv9XtDIc=
429429
open-cluster-management.io/api v0.13.1-0.20240411131856-8f6aa25f111c/go.mod h1:CuCPEzXDvOyxBB0H1d1eSeajbHqaeGEKq9c63vQc63w=
430-
open-cluster-management.io/sdk-go v0.13.1-0.20240416030555-aa744f426379 h1:8jXVHfgy+wgXq1mrWC1mTieoP77WsAAHNpzILMIzWB0=
431-
open-cluster-management.io/sdk-go v0.13.1-0.20240416030555-aa744f426379/go.mod h1:w2OaxtCyegxeyFLU42UQ3oxUz01QdsBQkcHI17T/l48=
430+
open-cluster-management.io/sdk-go v0.13.1-0.20240416062924-20307e6fe090 h1:zFmHuW+ztdfUUNslqNW+H1WEcfdEUQHoRDbmdajX340=
431+
open-cluster-management.io/sdk-go v0.13.1-0.20240416062924-20307e6fe090/go.mod h1:w2OaxtCyegxeyFLU42UQ3oxUz01QdsBQkcHI17T/l48=
432432
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.28.0 h1:TgtAeesdhpm2SGwkQasmbeqDo8th5wOBA5h/AjTKA4I=
433433
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.28.0/go.mod h1:VHVDI/KrK4fjnV61bE2g3sA7tiETLn8sooImelsCx3Y=
434434
sigs.k8s.io/controller-runtime v0.17.3 h1:65QmN7r3FWgTxDMz9fvGnO1kbf2nu+acg9p2R9oYYYk=

pkg/addon/controllers/addontemplate/controller.go

+5-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import (
2424
addoninformers "open-cluster-management.io/api/client/addon/informers/externalversions"
2525
addonlisterv1alpha1 "open-cluster-management.io/api/client/addon/listers/addon/v1alpha1"
2626
clusterv1informers "open-cluster-management.io/api/client/cluster/informers/externalversions"
27+
workv1client "open-cluster-management.io/api/client/work/clientset/versioned"
2728
workv1informers "open-cluster-management.io/api/client/work/informers/externalversions"
2829
clusterv1 "open-cluster-management.io/api/cluster/v1"
2930

@@ -40,6 +41,7 @@ type addonTemplateController struct {
4041

4142
kubeConfig *rest.Config
4243
addonClient addonv1alpha1client.Interface
44+
workClient workv1client.Interface
4345
kubeClient kubernetes.Interface
4446
cmaLister addonlisterv1alpha1.ClusterManagementAddOnLister
4547
addonInformers addoninformers.SharedInformerFactory
@@ -56,6 +58,7 @@ func NewAddonTemplateController(
5658
hubKubeconfig *rest.Config,
5759
hubKubeClient kubernetes.Interface,
5860
addonClient addonv1alpha1client.Interface,
61+
workClient workv1client.Interface,
5962
addonInformers addoninformers.SharedInformerFactory,
6063
clusterInformers clusterv1informers.SharedInformerFactory,
6164
dynamicInformers dynamicinformer.DynamicSharedInformerFactory,
@@ -67,6 +70,7 @@ func NewAddonTemplateController(
6770
kubeConfig: hubKubeconfig,
6871
kubeClient: hubKubeClient,
6972
addonClient: addonClient,
73+
workClient: workClient,
7074
cmaLister: addonInformers.Addon().V1alpha1().ClusterManagementAddOns().Lister(),
7175
addonManagers: make(map[string]context.CancelFunc),
7276
addonInformers: addonInformers,
@@ -205,7 +209,7 @@ func (c *addonTemplateController) runController(
205209
return err
206210
}
207211

208-
err = mgr.StartWithInformers(ctx, kubeInformers, c.workInformers, c.addonInformers, c.clusterInformers, c.dynamicInformers)
212+
err = mgr.StartWithInformers(ctx, c.workClient, c.workInformers.Work().V1().ManifestWorks(), kubeInformers, c.addonInformers, c.clusterInformers, c.dynamicInformers)
209213
if err != nil {
210214
return err
211215
}

pkg/addon/controllers/addontemplate/controller_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,7 @@ func TestReconcile(t *testing.T) {
176176
nil,
177177
hubKubeClient,
178178
fakeAddonClient,
179+
fakeWorkClient,
179180
addonInformers,
180181
clusterInformers,
181182
dynamicInformerFactory,

pkg/addon/manager.go

+3
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ func RunManager(ctx context.Context, controllerContext *controllercmd.Controller
7979
ctx, controllerContext,
8080
hubKubeClient,
8181
addonClient,
82+
workClient,
8283
clusterInformerFactory,
8384
addonInformerFactory,
8485
workInformers,
@@ -91,6 +92,7 @@ func RunControllerManagerWithInformers(
9192
controllerContext *controllercmd.ControllerContext,
9293
hubKubeClient kubernetes.Interface,
9394
hubAddOnClient addonv1alpha1client.Interface,
95+
hubWorkClient workv1client.Interface,
9496
clusterInformers clusterinformers.SharedInformerFactory,
9597
addonInformers addoninformers.SharedInformerFactory,
9698
workinformers workv1informers.SharedInformerFactory,
@@ -187,6 +189,7 @@ func RunControllerManagerWithInformers(
187189
controllerContext.KubeConfig,
188190
hubKubeClient,
189191
hubAddOnClient,
192+
hubWorkClient,
190193
addonInformers,
191194
clusterInformers,
192195
dynamicInformers,

vendor/modules.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -1489,7 +1489,7 @@ k8s.io/utils/pointer
14891489
k8s.io/utils/ptr
14901490
k8s.io/utils/strings/slices
14911491
k8s.io/utils/trace
1492-
# open-cluster-management.io/addon-framework v0.9.1-0.20240416063208-ecb7f349df05
1492+
# open-cluster-management.io/addon-framework v0.9.1-0.20240419070222-e703fc5a2556
14931493
## explicit; go 1.21
14941494
open-cluster-management.io/addon-framework/pkg/addonfactory
14951495
open-cluster-management.io/addon-framework/pkg/addonmanager
@@ -1578,7 +1578,7 @@ open-cluster-management.io/api/utils/work/v1/workapplier
15781578
open-cluster-management.io/api/utils/work/v1/workvalidator
15791579
open-cluster-management.io/api/work/v1
15801580
open-cluster-management.io/api/work/v1alpha1
1581-
# open-cluster-management.io/sdk-go v0.13.1-0.20240416030555-aa744f426379
1581+
# open-cluster-management.io/sdk-go v0.13.1-0.20240416062924-20307e6fe090
15821582
## explicit; go 1.21
15831583
open-cluster-management.io/sdk-go/pkg/apis/cluster/v1alpha1
15841584
open-cluster-management.io/sdk-go/pkg/apis/cluster/v1beta1

vendor/open-cluster-management.io/addon-framework/pkg/addonmanager/base_manager.go

+200
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/open-cluster-management.io/addon-framework/pkg/addonmanager/interface.go

+42
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)