Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ClusterManagementAddOn and ManagedClusterAddon API to v1beta1 #826

Open
haoqing0110 opened this issue Feb 11, 2025 · 6 comments
Open
Labels
enhancement New feature or request

Comments

@haoqing0110
Copy link
Member

haoqing0110 commented Feb 11, 2025

Describe the enhancement
A clear and concise description of what the enhancement request is.

The Addon configurations and install strategy features have been added for years. Create this issue to trace the API change need to do in the future:

  • ClusterManagementAddOn deprecated field to be removed in v1beta1:
    • spec.addOnConfiguration
    • spec.supportedConfigs rename to spec.defaultConfigs

Based on https://github.com/open-cluster-management-io/enhancements/tree/main/enhancements/sig-architecture/81-addon-lifecycle
ClusterManagementAddOn should remove SupportedConfigs, adds DefaultConfigs section to list the default add-on configurations. (Today SupportedConfigs is already and only used to set default configs, the actual supported configs are hard coded in the addon's code)

  • ManagedClusterAddon deprecated field to be removed in v1beta1:
    • spec.installNamespace
    • status.addOnConfiguration
    • status.configReferences.name & status.configReferences.namespace
    • status.configReferences.lastObservedGeneration
  • ManagedClusterAddon deprecated labels to be removed in v1beta1:
    • "open-cluster-management.io/addon-pre-delete"
    • "addon.open-cluster-management.io/hosted-manifest-location"
  • ManagedClusterAddon deprecated finalizer to be removed in v1beta1:
    • "cluster.open-cluster-management.io/addon-pre-delete"
    • "cluster.open-cluster-management.io/hosting-addon-pre-delete"
    • "cluster.open-cluster-management.io/hosting-manifests-cleanup"
@haoqing0110 haoqing0110 added the enhancement New feature or request label Feb 11, 2025
@haoqing0110
Copy link
Member Author

/cc @qiujian16 @elgnay @zhujian7

@Ankit152
Copy link

Hey can I work on this issue?

@mikeshng
Copy link
Member

Hey can I work on this issue?

Absolutely, we appreciate all contributions. Could you please coordinate with @haoqing0110 to determine what effort is needed here?

@haoqing0110 haoqing0110 changed the title Update ClusterManagementAddOn API Upgrade ClusterManagementAddOn and ManagedClusterAddon API to v1beta1 Feb 25, 2025
@haoqing0110
Copy link
Member Author

@Ankit152 Thank you for your interest in this! I just updated some more details in the description.
There will be a lot of changes to the API upgrade, and we will have some discussions and evaluations next, as well as log some subtasks. You are welcome to pick out some subtasks that interest you and contribute.

@Ankit152
Copy link

Sure. I would definitely work on it. I will reach out to you on slack. Thanks!

@haoqing0110
Copy link
Member Author

This task is removed from v1.0.0 release preparation, due to too much API changes and impact. The further discussions will still happen in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

3 participants