fix: only shut down active providers

The spec says that shutdown must shut down active providers,
but the current logic shuts down inactive providers.

This change fixes that. Separately, the spec might also need to be modified
to say "only" active providers.

Signed-off-by: Brandon Duffany <[email protected]>

Author: bduffany

openfeature/openfeature.go

@@ -89,4 +89,5 @@ func RemoveHandler(eventType EventType, callback EventCallback) {
 // Shutdown active providers
 func Shutdown() {
 	api.Shutdown()
+	initSingleton()
 }

openfeature/openfeature_test.go

@@ -558,29 +558,50 @@ func TestRequirement_1_1_7(t *testing.T) {
 func TestRequirement_1_6_1(t *testing.T) {
 	defer t.Cleanup(initSingleton)
 
-	provider, initSem, shutdownSem := setupProviderWithSemaphores()
+	provider1, _, shutdownSem1 := setupProviderWithSemaphores()
 
 	// Setup provider and wait for initialization done
-	err := SetProvider(provider)
+	err := SetProviderAndWait(provider1)
 	if err != nil {
 		t.Errorf("error setting up provider %v", err)
 	}
 
+	Shutdown()
+
+	// Shutdown should be synchronous. Try a non-blocking receive and fail
+	// immediately if there is not a value in the channel.
 	select {
-	// short enough wait time, but not too long
-	case <-time.After(100 * time.Millisecond):
-		t.Errorf("intialization timeout")
-	case <-initSem:
+	case <-shutdownSem1:
 		break
+	default:
+		t.Fatalf("shutdown not invoked")
+	}
+
+	// After shutting down the first provider, it should be inactive.
+	//
+	// The spec says that shutdown must shut down *active* providers. To test
+	// this, try shutting down again, and make sure that provider1 is not shut
+	// down again, since it is now inactive.
+	provider2, _, shutdownSem2 := setupProviderWithSemaphores()
+
+	err = SetProviderAndWait(provider2)
+	if err != nil {
+		t.Errorf("error setting up provider %v", err)
 	}
 
 	Shutdown()
 
 	select {
-	// short enough wait time, but not too long
+	case <-shutdownSem2:
+		break
+	default:
+		t.Fatalf("shutdown not invoked")
+	}
+
+	select {
+	case <-shutdownSem1:
+		t.Fatalf("provider1 should not have been shut down again, since it is inactive")
 	case <-time.After(100 * time.Millisecond):
-		t.Errorf("shutdown not invoked")
-	case <-shutdownSem:
 		break
 	}
 }