Skip to content

Commit 341d1e1

Browse files
committed
fix lint issues
Signed-off-by: Konvalinka <[email protected]>
1 parent d27e4e9 commit 341d1e1

File tree

3 files changed

+20
-11
lines changed

3 files changed

+20
-11
lines changed

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdOptions.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,8 @@ public class FlagdOptions {
129129
* Defaults to empty list
130130
*/
131131
@Builder.Default
132-
private List<String> fatalStatusCodes = fallBackToEnvOrDefaultList(Config.FATAL_STATUS_CODES_ENV_VAR_NAME, List.of());
132+
private List<String> fatalStatusCodes =
133+
fallBackToEnvOrDefaultList(Config.FATAL_STATUS_CODES_ENV_VAR_NAME, List.of());
133134

134135
/**
135136
* Selector to be used with flag sync gRPC contract.

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/connector/sync/SyncStreamQueueSource.java

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,11 @@ private void observeSyncStream() {
195195
observer.metadata = getMetadata();
196196
} catch (StatusRuntimeException metaEx) {
197197
if (fatalStatusCodes.contains(metaEx.getStatus().getCode().name()) && !successfulSync.get()) {
198-
log.debug("Fatal status code for metadata request: {}, not retrying", metaEx.getStatus().getCode());
199-
enqueueFatal(String.format("Fatal: Failed to connect for metadata request, not retrying for error %s", metaEx.getStatus().getCode()));
198+
log.debug("Fatal status code for metadata request: {}, not retrying",
199+
metaEx.getStatus().getCode());
200+
enqueueFatal(String.format(
201+
"Fatal: Failed to connect for metadata request, not retrying for error %s",
202+
metaEx.getStatus().getCode()));
200203
return;
201204
} else {
202205
// retry for other status codes
@@ -214,7 +217,9 @@ private void observeSyncStream() {
214217
} catch (StatusRuntimeException ex) {
215218
if (fatalStatusCodes.contains(ex.getStatus().getCode().toString()) && !successfulSync.get()) {
216219
log.debug("Fatal status code during sync stream: {}, not retrying", ex.getStatus().getCode());
217-
enqueueFatal(String.format("Fatal: Failed to connect for metadata request, not retrying for error %s", ex.getStatus().getCode()));
220+
enqueueFatal(String.format(
221+
"Fatal: Failed to connect for metadata request, not retrying for error %s",
222+
ex.getStatus().getCode()));
218223
return;
219224
} else {
220225
// retry for other status codes
@@ -289,16 +294,16 @@ private void enqueueError(String message) {
289294
enqueueError(outgoingQueue, message);
290295
}
291296

292-
private void enqueueFatal(String message) {
293-
enqueueFatal(outgoingQueue, message);
294-
}
295-
296297
private static void enqueueError(BlockingQueue<QueuePayload> queue, String message) {
297298
if (!queue.offer(new QueuePayload(QueuePayloadType.ERROR, message, null))) {
298299
log.error("Failed to convey ERROR status, queue is full");
299300
}
300301
}
301302

303+
private void enqueueFatal(String message) {
304+
enqueueFatal(outgoingQueue, message);
305+
}
306+
302307
private static void enqueueFatal(BlockingQueue<QueuePayload> queue, String message) {
303308
if (!queue.offer(new QueuePayload(QueuePayloadType.FATAL, message, null))) {
304309
log.error("Failed to convey FATAL status, queue is full");
@@ -313,7 +318,8 @@ private static class SyncStreamObserver implements StreamObserver<SyncFlagsRespo
313318

314319
private Struct metadata;
315320

316-
public SyncStreamObserver(BlockingQueue<QueuePayload> outgoingQueue, AtomicBoolean shouldThrottle, List<String> fatalStatusCodes) {
321+
public SyncStreamObserver(BlockingQueue<QueuePayload> outgoingQueue, AtomicBoolean shouldThrottle,
322+
List<String> fatalStatusCodes) {
317323
this.outgoingQueue = outgoingQueue;
318324
this.shouldThrottle = shouldThrottle;
319325
this.fatalStatusCodes = fatalStatusCodes;

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/rpc/RpcResolver.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -353,8 +353,10 @@ private void observeEventStream() throws InterruptedException {
353353
Throwable streamException = taken.getError();
354354
if (streamException != null) {
355355
if (streamException instanceof StatusRuntimeException && fatalStatusCodes.contains(
356-
((StatusRuntimeException) streamException).getStatus().getCode().name()) && !successfulConnection.get()) {
357-
log.debug("Fatal error code received: {}", ((StatusRuntimeException) streamException).getStatus().getCode());
356+
((StatusRuntimeException) streamException).getStatus().getCode().name())
357+
&& !successfulConnection.get()) {
358+
log.debug("Fatal error code received: {}",
359+
((StatusRuntimeException) streamException).getStatus().getCode());
358360
this.handleFatalError();
359361
} else {
360362
log.debug(

0 commit comments

Comments
 (0)