Commit 5325453
committed
docs(flagd): say what the new tags gate here, and what the testbed still owes
@Variants and @targeting arrived with the base's submodule bump, and
declarableExcept picks both up without a line of this file changing. That is the
right outcome and the reason nothing here said so, which is the problem: the
declaration grew by two capabilities and the file that argues every other one
either way was silent about them.
Two runs against flagd-testbed v3.8.0, one per resolver. RPC: 45 pass, 5
skipped, 2 failed. In-process: the same, after a first attempt whose opening
scenario timed out on a cold sync stream and passed on rerun -- a warm-up flake,
not a result. @targeting's three scenarios resolve targeting-key-flag through
flagd's own rule evaluation and pass in both modes on the image already pinned,
so the tag cost no bump; the Compose header now says so, because the note beside
that tag is where someone would otherwise go looking for a reason to bump it.
Both failures are the one testbed gap, and the @Variants outline reaches it a
second time: once for the untagged precision scenario, once for the row asking
for large-integer-flag's max-int32 variant. So the header's "one untagged
scenario" is a scenario short. Withholding @Variants would hide both -- and
would be a claim about flagd made to accommodate a missing flag, which is the
one thing a declaration must not be.
The capabilities() javadoc also still called @targeting reserved, in the
paragraph explaining why complementOf is the wrong call. It is declarable now,
and the paragraph is stronger for losing it: the reserved set shrinks as the
vocabulary fills up, so what protects the declaration is the form of the call
rather than the size of the set.
Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>1 parent dccbb8c commit 5325453
2 files changed
Lines changed: 23 additions & 6 deletions
File tree
- providers/flagd/src/test
- java/dev/openfeature/contrib/providers/flagd/e2e
- resources/tck
Lines changed: 15 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
166 | 176 | | |
167 | 177 | | |
168 | | - | |
169 | | - | |
170 | | - | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
171 | 183 | | |
172 | 184 | | |
173 | 185 | | |
| |||
Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
9 | 14 | | |
10 | 15 | | |
11 | 16 | | |
| |||
0 commit comments