Skip to content

Commit 8a5b839

Browse files
committed
feat(tck): report the revision that gated the reasons
tck.spec.revision follows the submodule to c342461a, so a report names the revision that actually produced its scenarios rather than the one before the reasons moved into reason.feature. Checked with help:evaluate against the module POM and against `git -C spec rev-parse HEAD`, which is the pair the property's comment says must agree. The one pinned expectation that had to move is the maximal declaration in ConformanceReportPluginTest: it lists every declarable tag in order, so @standard-reasons had to be added with the note saying why an opt-in claim is still an ordinary declarable capability. That test is the reason the list is pinned at all -- "everything" once meant EnumSet.allOf and published claims about capabilities no scenario examines. Nothing else on this branch pins a count. CanonicalScenarios reads the packaged gherkin directory out of the artifact's own code source, so the canonical set moved from 57 to 66 scenarios per suite with no edit, and CanonicalScenarioGuard compared the new set against the new plan. That is the under-collection guard doing the job it exists for: had the sixth feature file not been collected, the guard would have failed rather than the run going quietly green on a smaller question set. 272 tests, 43 skipped, up from 245 and 37. The 32-test gap to the base branch is unchanged. Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
1 parent e7ae05b commit 8a5b839

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

tools/tck/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
pin already moves only by deliberate commit. Update both together; a mismatch means a
4141
report names a revision that did not produce its scenarios.
4242
-->
43-
<tck.spec.revision>ccdb88790bb4f4beaef14a182d0c2592feab34b2</tck.spec.revision>
43+
<tck.spec.revision>c342461aa95df9e3b46320dbae65e88e5e8b815a</tck.spec.revision>
4444
<assertj.version>3.27.7</assertj.version>
4545
<awaitility.version>4.3.0</awaitility.version>
4646
<jackson-databind.version>2.22.1</jackson-databind.version>

tools/tck/src/test/java/dev/openfeature/contrib/tools/tck/ConformanceReportPluginTest.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,13 @@ void aReservedCapabilityCannotReachTheDeclaration() {
323323
Capability.LARGE_INTEGERS.tag(),
324324
// @targeting was reserved until targeting-key-flag's three scenarios
325325
// arrived. It gates something now, so the maximal claim includes it.
326-
Capability.TARGETING.tag());
326+
Capability.TARGETING.tag(),
327+
// @standard-reasons gates reason.feature in its entirety. It is a claim
328+
// rather than an exemption -- 2.2.5 lets a provider report "some other
329+
// string", so a provider that does not declare it is not thereby deficient
330+
// -- but it is an ordinary declarable capability all the same, and the
331+
// maximal claim includes it.
332+
Capability.STANDARD_REASONS.tag());
327333
}
328334

329335
@Test

0 commit comments

Comments
 (0)