Skip to content

Commit a97a728

Browse files
committed
test(flagsmith): pin the testbed image, and follow the compose path convention
The compose file moves to src/test/resources/tck/docker-compose.yaml, the path the TCK javadoc uses, and the image is pinned to 0.1.0 rather than :latest. Pinning is the substantive half. Four language adoptions pull this image, and a mutable tag lets a push to the testbed change four pull requests' results with no diff anywhere to explain it. The tag stays overridable through FLAGSMITH_TESTBED_IMAGE. 56 scenarios: 24 pass, 12 fail, 20 skip. Unchanged. Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
1 parent 78f9318 commit a97a728

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

providers/flagsmith/src/test/java/dev/openfeature/contrib/providers/flagsmith/FlagsmithProviderTckTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public class FlagsmithProviderTckTest extends ContainerizedProviderTckTest {
4040

4141
@Override
4242
public File composeFile() {
43-
return new File("src/test/resources/flagsmith-testbed-compose.yaml");
43+
return new File("src/test/resources/tck/docker-compose.yaml");
4444
}
4545

4646
@Override

providers/flagsmith/src/test/resources/flagsmith-testbed-compose.yaml renamed to providers/flagsmith/src/test/resources/tck/docker-compose.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@
33
#
44
# The service is named "backend" because that is ContainerizedProviderTckTest's default.
55
#
6+
# The image is PINNED, not :latest. Four language adoptions pull this image, and a mutable tag lets
7+
# a push to the testbed change four pull requests' results with no diff anywhere to explain it.
8+
#
69
# Ports are never pinned. The TCK reads the dynamically mapped host ports after the stack is up,
710
# and POST /stop deliberately never restarts the container precisely so those mappings survive an
811
# outage scenario.
912
services:
1013
backend:
11-
image: ${FLAGSMITH_TESTBED_IMAGE:-ghcr.io/aepfli/flagsmith-tck-testbed:latest}
14+
image: ${FLAGSMITH_TESTBED_IMAGE:-ghcr.io/aepfli/flagsmith-tck-testbed:0.1.0}
1215
ports:
1316
- 8000 # Edge Proxy -- what the provider under test talks to
1417
- 8080 # launchpad -- control API

0 commit comments

Comments
 (0)