ci: pullrequest action definitions with test-harness support (#16)

Signed-off-by: Tom Carrio <[email protected]>

Author: tcarrio

.github/workflows/pullrequest.yml

@@ -0,0 +1,93 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+
+name: PR
+
+on:
+  pull_request:
+    branches: [ main ]
+
+permissions:
+  contents: read
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        operating-system: [ubuntu-latest]
+        php-version: ['7.4', '8.0', '8.1']
+
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          submodules: true
+          fetch-depth: 0
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php-version }}
+          coverage: xdebug
+          extensions: ast
+
+      - name: Validate composer.json and composer.lock
+        run: composer validate
+
+      - name: Cache Composer packages
+        id: root-composer-cache
+        uses: actions/cache@v3
+        with:
+          path: vendor
+          key: ${{ runner.os }}-${{ matrix.php-version }}-php-${{ hashFiles('composer.json') }}
+          restore-keys: |
+            ${{ runner.os }}-${{ matrix.php-version }}-php-
+
+      - name: Install dependencies
+        if: steps.root-composer-cache.outputs.cache-hit != 'true'
+        run: composer install --prefer-dist --no-progress --no-suggest
+
+      - name: Check Style
+        run: vendor/bin/phpcs
+
+      - name: Run Psalm
+        run: vendor/bin/psalm --output-format=github --php-version=${{ matrix.php-version }}
+
+      - name: Run Phpstan
+        run: vendor/bin/phpstan analyse --error-format=github
+
+      - name: Run PHPUnit (unit tests)
+        run: vendor/bin/phpunit --coverage-text --coverage-clover=coverage.clover --testsuite unit
+
+      - name: Validate composer.json and composer.lock
+        working-directory: integration
+        run: composer validate
+
+      - name: Prepare test-harness
+        working-directory: integration
+        run: |
+          git submodule update --init --recursive
+          cp ./test-harness/features/*.feature ./features/
+
+      - name: Cache Composer packages
+        id: behat-composer-cache
+        uses: actions/cache@v3
+        with:
+          path: integration/vendor
+          key: ${{ runner.os }}-${{ matrix.php-version }}-php-${{ hashFiles('integration/composer.json') }}
+          restore-keys: |
+            ${{ runner.os }}-${{ matrix.php-version }}-php-
+
+      - name: Install dependencies
+        working-directory: integration
+        if: steps.behat-composer-cache.outputs.cache-hit != 'true'
+        run: composer install --prefer-dist --no-progress --no-suggest
+
+      - name: Start test-harness container
+        run: docker run --rm -d -p 8013:8013 ghcr.io/open-feature/flagd-testbed:latest
+
+      - name: Run Behat (integration tests)
+        working-directory: integration
+        run: vendor/bin/behat

.tool-versions

@@ -1 +1,3 @@
-php 7.4.30
+# php 7.4.30
+# php 8.0.24
+php 8.1.11

integration/composer.json

@@ -26,15 +26,6 @@
         "phpunit/phpunit": "^9.5"
     },
     "repositories": [
-        {
-            "type": "path",
-            "url": "../../openfeature-php-sdk-contrib/src/Flagd",
-            "options": {
-                "versions": {
-                    "open-feature/flagd-provider": "0.0.2"
-                }
-            }
-        },
         {
             "type": "path",
             "url": "../",

phpcs.xml.dist

@@ -23,6 +23,7 @@
 
         <!-- Ignore this for PHP 7.4 -->
         <exclude name="SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingNativeTypeHint"/>
+        <exclude name="SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint"/>
     </rule>
 
 </ruleset>

src/implementation/hooks/HookHints.php

@@ -8,6 +8,7 @@
 use OpenFeature\interfaces\hooks\HookHints as HookHintsInterface;
 
 use function array_keys;
+use function key_exists;
 
 class HookHints implements HookHintsInterface
 {
@@ -19,7 +20,11 @@ class HookHints implements HookHintsInterface
      */
     public function get(string $key)
     {
-        return $this->hints[$key];
+        if (key_exists($key, $this->hints)) {
+            return $this->hints[$key];
+        }
+
+        return null;
     }
 
     /**

tests/unit/OpenFeatureAPITest.php

@@ -80,7 +80,7 @@ public function testApiCanHaveProviderSet(): void
         $actualProvider = $api->getProvider();
 
         $this->assertInstanceOf(Provider::class, $actualProvider);
-        $this->assertInstanceOf(get_class($provider), $actualProvider);
+        $this->assertInstanceOf(get_class($provider), $actualProvider); // phpcs:ignore
     }
 
     /**