AvoidStarImport flags import x.y.*. 79 instances across 52 files.
Top offenders
opa-builtins-token/.../TokenBuiltins.java — 5
opa-evaluator/.../ir/Evaluator.java — 4
opa-evaluator/src/test/.../ir/PolicyTest.java — 4
opa-evaluator/.../ast/builtin/impls/ArithmeticBuiltins.java — 3 (incl. java.lang.Math.*)
- many test files using
Assertions.* and Mockito.*
Decision needed
Tests using Assertions.* and Mockito.* static-imports are idiomatic JUnit/Mockito style. Two reasonable resolutions:
- Expand them all (mechanical IDE fix).
- Add an exception for
org.junit.jupiter.api.Assertions and org.mockito.Mockito via <property name="excludes" value="..."/> on AvoidStarImport.
My lean: (2) for those two specific imports (matches community style), (1) for everything else.
AvoidStarImportflagsimport x.y.*. 79 instances across 52 files.Top offenders
opa-builtins-token/.../TokenBuiltins.java— 5opa-evaluator/.../ir/Evaluator.java— 4opa-evaluator/src/test/.../ir/PolicyTest.java— 4opa-evaluator/.../ast/builtin/impls/ArithmeticBuiltins.java— 3 (incl.java.lang.Math.*)Assertions.*andMockito.*Decision needed
Tests using
Assertions.*andMockito.*static-imports are idiomatic JUnit/Mockito style. Two reasonable resolutions:org.junit.jupiter.api.Assertionsandorg.mockito.Mockitovia<property name="excludes" value="..."/>onAvoidStarImport.My lean: (2) for those two specific imports (matches community style), (1) for everything else.