ConstantName flags static final fields that don't match ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 54 violations.
Where
- ~50 files in
opa-evaluator/.../ir/stmts/*Stmt.java, each with private static final String StmtType = "..." — should be STMT_TYPE.
- A handful of test files with constants like
objectMapper that should either lose static final (they're just helpers) or be renamed.
Fix
Mechanical. Each rename is local (constant is private), so this is one safe bulk PR. IDE refactor → rename handles all *Stmt.java cases.
Note: Stmt.java:10 is also flagged by TypeName for an interface field named STMT_TYPE — Checkstyle is misclassifying because of how it's declared. Leave that one to the long-tail mop-up issue.
ConstantNameflagsstatic finalfields that don't match^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$. 54 violations.Where
opa-evaluator/.../ir/stmts/*Stmt.java, each withprivate static final String StmtType = "..."— should beSTMT_TYPE.objectMapperthat should either losestatic final(they're just helpers) or be renamed.Fix
Mechanical. Each rename is local (constant is private), so this is one safe bulk PR. IDE refactor → rename handles all
*Stmt.javacases.Note:
Stmt.java:10is also flagged byTypeNamefor an interface field namedSTMT_TYPE— Checkstyle is misclassifying because of how it's declared. Leave that one to the long-tail mop-up issue.