Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing canonical tags #331

Closed
wants to merge 2 commits into from

Conversation

CBID2
Copy link

@CBID2 CBID2 commented Jun 29, 2024

Description

This PR adds a canonical tag for the blogs, improving its SEO.

Related Tickets & Documents

Closes #313

Mobile & Desktop Screenshots/Recordings

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Lets hope this works GIF

Copy link

netlify bot commented Jun 29, 2024

Deploy Preview for opensauced-landing ready!

Name Link
🔨 Latest commit 6fbdf88
🔍 Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/6685a02afe51120009eb792e
😎 Deploy Preview https://deploy-preview-331--opensauced-landing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CBID2
Copy link
Author

CBID2 commented Jun 29, 2024

Hey @BekahHW! :) I made a draft PR for this issue. I hope it is what you had in mind.

@BekahHW
Copy link
Member

BekahHW commented Jun 29, 2024

@CBID2 we'll be merging in a PR before this that upgrades sanity studio, so let's wait until that gets merged in. You'll need to check each of the pages on the checklist to make sure they have the correct canonical_url. It looks like the blog posts are getting picked up, but there are other pages on the list. We can potentially break it into two issues though.

@CBID2
Copy link
Author

CBID2 commented Jun 29, 2024

@CBID2 we'll be merging in a PR before this that upgrades sanity studio, so let's wait until that gets merged in. You'll need to check each of the pages on the checklist to make sure they have the correct canonical_url. It looks like the blog posts are getting picked up, but there are other pages on the list. We can potentially break it into two issues though.

Good idea @BekahHW. I think for the second part of this issue, having some sort of example on how to add the canonical link would help.

@BekahHW
Copy link
Member

BekahHW commented Jul 1, 2024

Good idea @BekahHW. I think for the second part of this issue, having some sort of example on how to add the canonical link would help.

If it were a good-first-issue, I would have an example. Taking a look at the codebase and checking documentation should lead you on the right path.

@BekahHW
Copy link
Member

BekahHW commented Jul 3, 2024

@CBID2 can you merge in the latest changes and give me an update on how the issues going when you get a chance?

@CBID2
Copy link
Author

CBID2 commented Jul 3, 2024

@CBID2 can you merge in the latest changes and give me an update on how the issues going when you get a chance?

Hey @BekahHW. I just updated my branch with the latest changes. I'm currently working on my PR via Gitpod(I tried doing it locally but my computer runs slow when I do) and I get this message whenever I click on the Editing SEO Content link in the Readme
Screenshot of error.
According to Gitpod's Docs, it is recommended to Configure the port, but I'm a bit hesitant to do that as I don't want to mess up the main repo. What do you recommend?

@BekahHW
Copy link
Member

BekahHW commented Jul 3, 2024

I haven't used gitpod before. What other resources did you look at to navigate the issues you're having?

@BekahHW
Copy link
Member

BekahHW commented Jul 16, 2024

@CBID2 do you have an update here? I'd like to get the issue completed soon.

@CBID2
Copy link
Author

CBID2 commented Jul 16, 2024

@CBID2 do you have an update here? I'd like to get the issue completed soon.

Hey @BekahHW. I tried finding another alternative but couldn't find one.😔

@CBID2
Copy link
Author

CBID2 commented Jul 16, 2024

@CBID2 do you have an update here? I'd like to get the issue completed soon.

Seems like this method with Gitpod is the only one I can do: https://www.gitpod.io/docs/configure/workspaces/ports

@CBID2 CBID2 closed this Aug 6, 2024
@CBID2 CBID2 deleted the adding-cannonical-links branch August 6, 2024 22:04
@CBID2
Copy link
Author

CBID2 commented Aug 6, 2024

Hey @BekahHW. I decided to close this PR. You can work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Missing Canonical Tags
2 participants