Skip to content

Commit

Permalink
Merge pull request #221 from btolfa/forgotten-virtual-dtor
Browse files Browse the repository at this point in the history
Added forgotten virtual dtor for `Json::CharReader::Factory`.

(Without this, the destructor of the derived `CharReaderBuilder` would not be called, which is a small memory leak.)
  • Loading branch information
cdunn2001 committed Mar 15, 2015
2 parents 951bd3d + be183de commit cbe7e7c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions include/json/reader.h
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@ class JSON_API CharReader {

class Factory {
public:
virtual ~Factory() {}
/** \brief Allocate a CharReader via operator new().
* \throw std::exception if something goes wrong (e.g. invalid settings)
*/
Expand Down

0 comments on commit cbe7e7c

Please sign in to comment.