[cmd/opampsupervisor] allow configuring collector process execution #37331
Conversation
github-actions
bot
requested review from
atoulme,
evan-bradley and
tigrannajaryan
odubajDT
force-pushed
the
opamp-process-execution
branch
2 times, most recently
from
b8da560 to
5ffbcfd
Compare
odubajDT
force-pushed
the
opamp-process-execution
branch
from
28c7104 to
e272468
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
| c.logger.Debug("Starting agent", zap.String("agent", c.cfg.Executable)) | ||
|
|
||
| for _, conf := range c.cfg.ConfigFiles { | ||
| fileName := filepath.Base(conf) | ||
| newPath := c.logsDir + "/" + fileName |
There was a problem hiding this comment.
Thoughts on putting these configs in a sub folder called "configs" or something to keep the storage directory a bit more organized?
There was a problem hiding this comment.
not sure if a separate folder/package is a good solution here, but moved it at least to a separate function and moved the more general functions to a separate package
There was a problem hiding this comment.
Sorry, I mean the location the files get moved to. If we can consider creating a new configs folder so that the supervisor's storage directory doesn't get too cluttered in the event a user is running with several configs.
|
@evan-bradley @tigrannajaryan PTAL when you're able. I think this would be a great addition and it is working well in my testing. |
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
opamp-process-execution
branch
from
e272468 to
9f50081
Compare
Signed-off-by: odubajDT <[email protected]>
Description
Allow configuring collector process via additional parameters:
config_files- list of additional config files passed into the collectorenv- map of env variables passed to the collector processargs- additional arguments passed to the collector process on startupLink to tracking issue
Fixes #24324