Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tailsampling processor: Add support for logs #2636

Open
BinaryHexer opened this issue Mar 11, 2021 · 5 comments
Open

tailsampling processor: Add support for logs #2636

BinaryHexer opened this issue Mar 11, 2021 · 5 comments
Labels
enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed processor/tailsampling Tail sampling processor

Comments

@BinaryHexer
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Allow logs to be sampled based on the same logic as traces (grouping by traceID) to enable tail sampling for distributed logs for requests spanning multiple services.

Describe the solution you'd like
Add implementation for the component.LogsProcessor interface to the existing tailsamplingprocessor.

Describe alternatives you've considered
N/A

Additional context
N/A

@BinaryHexer
Copy link
Contributor Author

@jpkrohling
Sorry for mentioning you here, but I just saw #1797.
Considering the context of the above issue, what would be best strategy to proceed if support for sampling for logs is to be considered?

@jpkrohling
Copy link
Member

It's still not clear to me what's the future of the current tail-sampling. I have it in my queue to run some performance tests and assess whether we should deprecate it in favor of a more granular set of processors. Until a decision is made, I would not invest much time in a prototype for tail-based sampling for logs.

@alolita alolita added the processor/tailsampling Tail sampling processor label Sep 30, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 4, 2022
@jpkrohling jpkrohling added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Nov 30, 2022
@crobert-1 crobert-1 added the enhancement New feature or request label Sep 15, 2023
@sinkingpoint
Copy link
Contributor

sinkingpoint commented Nov 10, 2023

@jpkrohling @crobert-1 was there ever any progress on this? It seems like the tailsamplingprocessor is still around and not deprecated. I've run into a need for this myself, and have (mostly?) implemented it internally at Cloudflare so happy to cut a PR. Something to discuss at the next SIG meeting?

@jpkrohling
Copy link
Member

@sinkingpoint, absolutely, we can certainly discuss this. If you are on the CNCF Slack, you might want to join #otel-sampling as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed processor/tailsampling Tail sampling processor
Projects
None yet
Development

No branches or pull requests

5 participants