-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tailsampling processor: Add support for logs #2636
Comments
@jpkrohling |
It's still not clear to me what's the future of the current tail-sampling. I have it in my queue to run some performance tests and assess whether we should deprecate it in favor of a more granular set of processors. Until a decision is made, I would not invest much time in a prototype for tail-based sampling for logs. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@jpkrohling @crobert-1 was there ever any progress on this? It seems like the tailsamplingprocessor is still around and not deprecated. I've run into a need for this myself, and have (mostly?) implemented it internally at Cloudflare so happy to cut a PR. Something to discuss at the next SIG meeting? |
@sinkingpoint, absolutely, we can certainly discuss this. If you are on the CNCF Slack, you might want to join #otel-sampling as well. |
Is your feature request related to a problem? Please describe.
Allow logs to be sampled based on the same logic as traces (grouping by traceID) to enable tail sampling for distributed logs for requests spanning multiple services.
Describe the solution you'd like
Add implementation for the
component.LogsProcessor
interface to the existingtailsamplingprocessor
.Describe alternatives you've considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: